AAE-35668 Sending empty string instead of null after clearing value from numeric field #10925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures the number widget correctly handles null, undefined, and empty string values, setting the field value to null in these cases. This change prevents unexpected behavior when the user clears the input field, ensuring data consistency.
mkrbr
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
Adds a test case to verify the behavior of the number widget when it's in readonly mode. The test checks if the displayValue is correctly set using the decimalNumberPipe when the readOnly property is true.
eromano
approved these changes
Jun 11, 2025
…tead-of-null-after-clearing-value-from-numeric-field
Updates number widget tests to use `overrideComponent` for providing mocked dependencies. This approach ensures proper isolation and avoids potential issues with shared state between tests. Additionally, it adds a test case to verify the `displayValue` is correctly set using the mocked `DecimalNumberPipe`.
…tring-instead-of-null-after-clearing-value-from-numeric-field' into fix/AAE-35668-fe-sending-empty-string-instead-of-null-after-clearing-value-from-numeric-field
|
mkrbr
deleted the
fix/AAE-35668-fe-sending-empty-string-instead-of-null-after-clearing-value-from-numeric-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the number widget correctly handles null, undefined, and empty string values, setting the field value to null in these cases.
This change prevents unexpected behavior when the user clears the input field, ensuring data consistency.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Empty string is send when number field is cleared in form.
https://hyland.atlassian.net/browse/AAE-35668
What is the new behaviour?
Null is send when number field is cleared in form.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: