Skip to content

Conversation

@alep85
Copy link
Contributor

@alep85 alep85 commented May 27, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
AlfrescoApiLoaderService.init() run before loadAppConfig factory so the init() function is not executed

What is the new behaviour?
When the angularAlfrescoApiService.init() is executed loads the security options setting auth.withCredentials

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…fvice is initialized because on content app the app-config.loader is run after AlfrescoApiLoaderService.init and the callback function that should setDefaultSecurityOption is not executed
@sonarqubecloud
Copy link

@alep85 alep85 merged commit 467a19f into develop May 29, 2025
29 of 31 checks passed
@alep85 alep85 deleted the fix/AAE-34959-application-cors-issue-on-content branch May 29, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants