AAE-27160 Fix the structure of data returned from service-tasks API #10711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdonnell-hyland
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
sdonnell-hyland
requested review from
DavidOlson-Hyland,
ajcndn,
amolodyh-hyland,
csandham,
d-lowery,
dthornton-hyl and
jcain82
sdonnell-hyland
changed the title
dthornton-hyl
approved these changes
Mar 12, 2025
Contributor
dthornton-hyl
left a comment
dthornton-hyl
left a comment
There was a problem hiding this comment.
Approve if others agree with the breaking change.
DavidOlson-Hyland
approved these changes
Mar 12, 2025
jcain82
approved these changes
Mar 13, 2025
DenysVuika
approved these changes
Mar 13, 2025
sdonnell-hyland
force-pushed
the
fix/AAE-27160-service-task-sort
branch
from
4e04593 to
5fa5056
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
AAE-27160
Columns in the service task list cannot be sorted. This is because the sortKey doesn't match column key since there is an additional layer in the data (
entry). Attempting to update the sortKey to match, for exampleentry.startDate, allows the columns to sort correctly, but API calls includeentry.startDateas the column name in query parameters.During review, I noticed some mock data was actually correct and contained the
entrynode in data. This change is breaking, but provides consistency with similar components.What is the new behaviour?
Server data is filtered and mapped to exclude the extra
entrylayer.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Applications that use this component will need to update the
keyvalue in their column definitions as well as update the success callback and ng-template that use the data. For Hyland Experience, this specifically means the app.config.json templates need to be updated for both admin-apa and admin-hxp.