Skip to content

Conversation

@nikita-web-ua
Copy link
Contributor

@nikita-web-ua nikita-web-ua commented Jan 17, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/ACS-8824

  • Some forbidden symbols ignored by validator
  • Save button is active when form has errors

What is the new behaviour?

  • Disable save button if property validation fails
  • Add missing forbidden symbols to validator

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@nikita-web-ua nikita-web-ua marked this pull request as ready for review January 17, 2025 17:41
@sonarqubecloud
Copy link

@nikita-web-ua nikita-web-ua merged commit eaa1008 into develop Jan 28, 2025
18 checks passed
@nikita-web-ua nikita-web-ua deleted the dev-mmaliarchuk/ACS-8824-node-properties-save-button-validation branch January 28, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants