-
Notifications
You must be signed in to change notification settings - Fork 277
[ACS-8921][ACA] Data Table / The input field in "Filter by Name" dialog is enormous in comparison with the UI design #10375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-8921][ACA] Data Table / The input field in "Filter by Name" dialog is enormous in comparison with the UI design #10375
Conversation
|
|
||
| #{$mat-floating-label} { | ||
| left: 0; | ||
| #{$mat-form-field-wrapper}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to switch away from mat selectors. Since this is a component specific css file, is it not possible to use something like classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's inner element of angular material, so we can't add any custom class to it. It's mostly reformatting, as it was already added here
MichalKinas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I just took a look at the JIRA, and there is a much simpler way of resolving this bug. All that is needed, is to remove the On a side note, I remember this bug being fixed during the ng15 upgrade as well (see ACS-8429). Don't know what caused it to re-appear, could be a miss during rebase. But regardless, we should probably make sure not to miss it during the ng17 upgrade |
3c7927b to
d126c7c
Compare
…og is enormous in comparison with the UI design
…og is enormous in comparison with the UI design
…og is enormous in comparison with the UI design
d126c7c to
88d3406
Compare
|




Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8921
What is the new behaviour?
Filter is fixed
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: