Skip to content

Conversation

@dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/ACS-8921

What is the new behaviour?
Filter is fixed

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:


#{$mat-floating-label} {
left: 0;
#{$mat-form-field-wrapper},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to switch away from mat selectors. Since this is a component specific css file, is it not possible to use something like classes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's inner element of angular material, so we can't add any custom class to it. It's mostly reformatting, as it was already added here

Copy link
Contributor

@MichalKinas MichalKinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues present still, for example when entering the value input is not aligned properly
Zrzut ekranu 2024-11-12 o 09 47 49

@swapnil-verma-gl
Copy link
Contributor

swapnil-verma-gl commented Nov 12, 2024

I just took a look at the JIRA, and there is a much simpler way of resolving this bug. All that is needed, is to remove the appearance=outline property from the input text field in HTML (located here). That changes the UI of the text field to something more consistent with the rest of the application. Additionally, it also allows us to remove the mat-selectors from the scss file as well. I tried on my local with the proposed change, and a completely empty scss file and it looked fine, except for some minor padding/spacing issues, which should not be too hard to fix.

On a side note, I remember this bug being fixed during the ng15 upgrade as well (see ACS-8429). Don't know what caused it to re-appear, could be a miss during rebase. But regardless, we should probably make sure not to miss it during the ng17 upgrade

@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-8921-aca-data-table-the-input-field-in-filter-by-name-dialog-is-enormous-in-comparison-with-the-ui-design branch from 3c7927b to d126c7c Compare November 14, 2024 07:19
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-8921-aca-data-table-the-input-field-in-filter-by-name-dialog-is-enormous-in-comparison-with-the-ui-design branch from d126c7c to 88d3406 Compare November 14, 2024 08:09
@sonarqubecloud
Copy link

@dominikiwanekhyland dominikiwanekhyland merged commit 472671b into develop Nov 14, 2024
17 checks passed
@dominikiwanekhyland dominikiwanekhyland deleted the ACS-8921-aca-data-table-the-input-field-in-filter-by-name-dialog-is-enormous-in-comparison-with-the-ui-design branch November 14, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants