Skip to content

Revert "AAE-23521 Fix improve dropdown reactive form" #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2024
Merged

Revert "AAE-23521 Fix improve dropdown reactive form" #10068

merged 3 commits into from
Aug 9, 2024

Conversation

@VitoAlbano
Copy link
Contributor

@VitoAlbano VitoAlbano commented Aug 9, 2024

Reverts #10040

@ehsan-2019 ehsan-2019 force-pushed the revert-10040-fix/AAE-23521-improve-dropdown-reactive-form branch from 2a60f73 to 03fcfed Compare August 9, 2024 12:31
@VitoAlbano
Revert "AAE-23521 Fix improve dropdown reactive form (#10040)"
8dfc458 
This reverts commit f88ff10.
@VitoAlbano
Revert "AAE-24371 Fix invalid endpoint is called when process with fo…
4c6fe1d 
…rm is st… (#10052)"

This reverts commit d38e782.
@VitoAlbano
Revert "Revert "AAE-24371 Fix invalid endpoint is called when process…
b1f9ea1 
… with form is st… (#10052)""

This reverts commit 125ada76f61ab7a258503dbc51d09950073f9a95.
@VitoAlbano VitoAlbano force-pushed the revert-10040-fix/AAE-23521-improve-dropdown-reactive-form branch from 57c1b0d to b1f9ea1 Compare August 9, 2024 13:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ehsan-2019 ehsan-2019 merged commit 554218d into develop Aug 9, 2024
@ehsan-2019 ehsan-2019 deleted the revert-10040-fix/AAE-23521-improve-dropdown-reactive-form branch August 9, 2024 14:01
ehsan-2019 added a commit that referenced this pull request Aug 9, 2024
@ehsan-2019
Revert "Revert "AAE-23521 Fix improve dropdown reactive form" (#10068)"
28371d3 
This reverts commit 554218d.
@ehsan-2019 ehsan-2019 mentioned this pull request Aug 9, 2024
Merged
kathrine0 pushed a commit that referenced this pull request Sep 2, 2024
@ehsan-2019 @kathrine0
Revert "Revert "AAE-23521 Fix improve dropdown reactive form" (#10068)"
61be1f5 
This reverts commit 554218d.
kathrine0 added a commit that referenced this pull request Sep 2, 2024
@ehsan-2019 @kathrine0
Revert "Revert "AAE-23521 Fix improve dropdown reactive form"" (#10073)
beae405 
* Revert "Revert "AAE-23521 Fix improve dropdown reactive form" (#10068)"

This reverts commit 554218d.

* AAE-23521 fix trigger error check

* AAE-23521 improve standalone import

---------

Co-authored-by: Kasia Biernat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsan-2019 ehsan-2019 ehsan-2019 approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VitoAlbano @ehsan-2019