Skip to content

Conversation

alxgomz
Copy link
Contributor

@alxgomz alxgomz commented Sep 22, 2025

Checklist

  • Jira Reference (also in PR title):
  • README updated after adding/changing behaviour of an action
  • Proposed version increment for release:
    • Patch (bugfix)
    • Minor (new feature)
    • Major (breaking changes)
  • External PR link where changes has been tested:

Description

Ref: OPSEXP-3343

  • Allow overridding KinD configuration
  • Skip nginx ingress installation

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 15:30
@alxgomz alxgomz requested a review from a team as a code owner September 22, 2025 15:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the KinD (Kubernetes in Docker) setup action to provide more flexibility during cluster creation by allowing custom configuration overrides and optional nginx ingress installation.

  • Add support for custom KinD configuration via YAML string override
  • Allow skipping nginx ingress installation by setting the reference to "skip" or "none"
  • Update documentation to reflect new configuration options

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/README.md Documents new kind-config-override parameter and skip option for nginx ingress
.github/actions/setup-kind/action.yml Implements configuration override functionality and conditional nginx ingress installation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alxgomz alxgomz force-pushed the opsexp-3343-kindCfgOverride branch 2 times, most recently from db0fd5c to 4053ac3 Compare September 23, 2025 13:09
@alxgomz alxgomz force-pushed the opsexp-3343-kindCfgOverride branch from 12299cc to 4081e05 Compare September 25, 2025 07:51
@alxgomz alxgomz force-pushed the opsexp-3343-kindCfgOverride branch 4 times, most recently from e480132 to 2462cf6 Compare September 25, 2025 08:27
@alxgomz alxgomz force-pushed the opsexp-3343-kindCfgOverride branch from 2462cf6 to f18418d Compare September 25, 2025 08:30
@alxgomz alxgomz requested a review from gionn September 25, 2025 08:36
@alxgomz alxgomz force-pushed the opsexp-3343-kindCfgOverride branch from 4549cee to 3e206e3 Compare September 25, 2025 12:16
@alxgomz alxgomz requested a review from gionn September 25, 2025 12:16
@gionn gionn changed the title OPSEXP-3343: Allow overridding KinD configuration at creation time & skip nginx ingress installation OPSEXP-3343: Allow overridding KinD configuration & skip nginx ingress installation Sep 25, 2025
@alxgomz alxgomz merged commit 162c67e into master Sep 25, 2025
6 checks passed
@alxgomz alxgomz deleted the opsexp-3343-kindCfgOverride branch September 25, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants