-
Notifications
You must be signed in to change notification settings - Fork 4
OPSEXP-3343: Allow overridding KinD configuration & skip nginx ingress installation #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the KinD (Kubernetes in Docker) setup action to provide more flexibility during cluster creation by allowing custom configuration overrides and optional nginx ingress installation.
- Add support for custom KinD configuration via YAML string override
- Allow skipping nginx ingress installation by setting the reference to "skip" or "none"
- Update documentation to reflect new configuration options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
docs/README.md | Documents new kind-config-override parameter and skip option for nginx ingress |
.github/actions/setup-kind/action.yml | Implements configuration override functionality and conditional nginx ingress installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
db0fd5c
to
4053ac3
Compare
12299cc
to
4081e05
Compare
e480132
to
2462cf6
Compare
2462cf6
to
f18418d
Compare
4549cee
to
3e206e3
Compare
Checklist
Description
Ref: OPSEXP-3343