Skip to content

Conversation

atchertchian
Copy link
Contributor

@atchertchian atchertchian commented Jun 18, 2025

Checklist

Description

This introduces new actions to:

An old related action that is not following good practices anyway was also removed.

@atchertchian atchertchian marked this pull request as ready for review June 19, 2025 15:54
@atchertchian atchertchian requested a review from a team as a code owner June 19, 2025 15:54
@atchertchian atchertchian marked this pull request as draft June 19, 2025 18:51
@atchertchian atchertchian marked this pull request as ready for review June 19, 2025 18:51
@atchertchian
Copy link
Contributor Author

commenting to see if it triggers pull_request_review event to check https://github.com/Alfresco/alfresco-build-tools/actions/workflows/pr-review-check.yml

@atchertchian atchertchian force-pushed the improvement/AAE-35226-dependabot-validation branch from f19ecc6 to f816cb3 Compare June 23, 2025 11:46
@atchertchian atchertchian requested a review from gionn June 23, 2025 11:47
@dsibilio dsibilio requested a review from Copilot June 24, 2025 07:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new GitHub Actions to improve Dependabot PR validation and auto-merge workflows, removes an outdated Dependabot action, and bumps the tool’s version to v9.0.0.

  • Introduce github-require-secrets (fails early if secrets aren’t available) and github-trigger-approved-pr (labels/milestones and auto-merges on approval).
  • Remove deprecated automate-dependabot action.
  • Update Dependabot schedules in .github/dependabot.yml and bump version.txt to v9.0.0.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/README.md Removed automate-dependabot docs, added new sections and TOC entries for the new actions.
version.txt Bumped version from v8.24.1 to v9.0.0.
.github/dependabot.yml Dropped old Dependabot action schedule and added schedules for the new actions.
.github/actions/github-require-secrets/action.yml New composite action to enforce valid secret sources before running workflows.
.github/actions/github-trigger-approved-pr/action.yml New composite action to trigger validation, label/milestone PRs, and optionally auto-merge.
.github/actions/automate-dependabot/action.yml Deleted legacy Dependabot automation action.
Comments suppressed due to low confidence (4)

.github/dependabot.yml:252

  • Indentation for the new - package-ecosystem entries is inconsistent with existing blocks (4 spaces vs. 2). Align all entries to the same indent level to keep the YAML valid.
  - package-ecosystem: "github-actions"

.github/actions/github-require-secrets/action.yml:12

  • GitHub sets github.secret_source to lowercase values ('dependabot', 'actions', 'codespaces'). Update string comparisons to lowercase to avoid always failing.
        if [[ $SECRET_SOURCE == 'Dependabot' ]]

.github/actions/github-trigger-approved-pr/action.yml:75

  • Expressions inside single-quoted strings in github-script won’t be interpolated. Use JS templating (e.g., ``body: `Setting auto-merge on PR after action from @${process.env.ACTOR}```) or build the string in YAML before passing.
            body: 'Setting auto-merge on Dependabot PR after action from @${{ env.ACTOR }}',

.github/actions/github-trigger-approved-pr/action.yml:78

  • [nitpick] Step name references "propagation" but this action is generic to any approved PR. Consider renaming to something like "Enable auto-merge for approved PR" for clarity.
    - name: Enable auto-merge for propagation Pull Request

Copy link
Contributor

@dsibilio dsibilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Note: there's a rogue reference to the "propagation" that should be slashed off

@atchertchian atchertchian marked this pull request as draft July 22, 2025 07:41
@atchertchian atchertchian marked this pull request as ready for review September 24, 2025 17:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good and I understand the different use cases. It may be worth adding an item in the cookbook section to describe the approach of using these actions together, since looking at them individually may not fully reveal their purpose.

@atchertchian atchertchian merged commit 961c2a4 into master Sep 26, 2025
4 checks passed
@atchertchian atchertchian deleted the improvement/AAE-35226-dependabot-validation branch September 26, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants