Skip to content

[7.4-stable] fix(DatetimeView): Use settings value if present #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025

Conversation

alchemycms-bot
Copy link
Collaborator

Backport

This will backport the following commits from main to 7.4-stable:

Questions ?

Please refer to the Backport tool documentation

If we have an ingredient settings value we need to use
that and only use the argument from the view if present.

Only fallback to the default format if neither is present.

(cherry picked from commit 0d3ce02)
@tvdeyen tvdeyen force-pushed the backport/7.4-stable/pr-3348 branch from 07c2ce8 to dc08ab9 Compare August 15, 2025 20:44
@tvdeyen tvdeyen enabled auto-merge August 15, 2025 20:45
@tvdeyen tvdeyen merged commit 034fb2c into 7.4-stable Aug 15, 2025
96 of 97 checks passed
@tvdeyen tvdeyen deleted the backport/7.4-stable/pr-3348 branch August 15, 2025 21:25
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.48%. Comparing base (60cef5a) to head (dc08ab9).
⚠️ Report is 2 commits behind head on 7.4-stable.

Additional details and impacted files
@@             Coverage Diff             @@
##           7.4-stable    #3350   +/-   ##
===========================================
  Coverage       96.48%   96.48%           
===========================================
  Files             239      239           
  Lines            6465     6466    +1     
===========================================
+ Hits             6238     6239    +1     
  Misses            227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants