[7.4-stable] Add explicit strict mode in components index file #3337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
backport/7.4-stable/pr-3331
branch
from
daa6643 to
3475bf9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.4-stable #3337 +/- ##
===========================================
Coverage 96.48% 96.48%
===========================================
Files 239 239
Lines 6465 6465
===========================================
Hits 6238 6238
Misses 227 227 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
backport/7.4-stable/pr-3331
branch
from
3475bf9 to
e412444
Compare
If this file gets compiled with terser via sprockets it complain about top-level await is not available. This code will always ever run in context of a module, which implicitely implies strict mode, but Terser need this hint anyway. Refs ahorek/terser-ruby#62 Closes #3245 (cherry picked from commit 1c19cd4)
tvdeyen
force-pushed
the
backport/7.4-stable/pr-3331
branch
from
e412444 to
2e6b09e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.4-stable:Questions ?
Please refer to the Backport tool documentation