Add attachment "deletable" filter and show usage #3335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
==========================================
+ Coverage 97.04% 97.10% +0.05%
==========================================
Files 274 276 +2
Lines 7168 7207 +39
==========================================
+ Hits 6956 6998 +42
+ Misses 212 209 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
attachment-deletable-scope
branch
from
970bd75 to
9c51ed3
Compare
tvdeyen
changed the title
tvdeyen
force-pushed
the
attachment-deletable-scope
branch
2 times, most recently
from
f6791b6 to
15550b3
Compare
tvdeyen
force-pushed
the
attachment-deletable-scope
branch
2 times, most recently
from
9a62096 to
77cd42f
Compare
A convenient module that provides scopes, methods and relations for resources that are relatable to ingredients having a `related_object_alias` like `Alchemy::Picture` or `Alchemy::Attachment`.
This provides us with the `deletable` filter.
Custom elements behave like inline elements not taking any space in the DOM. We want the tooltip to be placed around the whole button, but just the text of the button. This fixes it
Make it reusable for other resources and adjust the style to be more pleasant.
Make it a bit darker for better contrast to the form background
This was a hard-coded color. Need to use border-color here.
As with the picture we want to show the pages and elements a file is used on.
tvdeyen
force-pushed
the
attachment-deletable-scope
branch
from
77cd42f to
610568a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
As with the picture we want to show the pages and elements a file is used on and make it only deletable if it has not been attached yet.
Notable changes
Rebuilds the attachment preview dialog in order to show file usage in nice way without removing the
preview feature and make room for the usages list.
Screenshots
Checklist