Skip to content

Conversation

ItsWendell
Copy link
Contributor

Description

Replaces hono with hono/tiny and replaces zod with valibot for a reduced bundle size and increased startup time.

Fixes #536

How Has This Been Tested?

pnpm test

@ItsWendell ItsWendell requested a review from AdiRishi as a code owner August 19, 2024 15:23
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 27e20cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
turborepo-remote-cache-cf Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ItsWendell ItsWendell marked this pull request as draft August 19, 2024 15:23
@ItsWendell
Copy link
Contributor Author

ItsWendell commented Aug 19, 2024

I ran this through bundlejs.com - includes config / results? and got result of Bundle size is 32.4 kB -> 11.2 kB (gzip)

Copy link
Owner

@AdiRishi AdiRishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to ensure all the unit tests in CI still pass.
You'll also need to commit the updated lockfile

@ItsWendell
Copy link
Contributor Author

Bundle size is 32.5 kB -> 11.2 kB (gzip)

@AdiRishi AdiRishi marked this pull request as ready for review August 20, 2024 10:02
@coveralls
Copy link

coveralls commented Aug 20, 2024

Pull Request Test Coverage Report for Build 10470983331

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.447%

Totals Coverage Status
Change from base Build 10447302911: 0.02%
Covered Lines: 170
Relevant Lines: 176

💛 - Coveralls

@AdiRishi
Copy link
Owner

@ItsWendell PR looks good, could you add a changeset file? You can do so by running npx changeset.
I think we can call this a major change. Feel free to add a nice description, it will be in the releases when I publish a new release.

FYI this is the makeup of your final build.
image

AdiRishi
AdiRishi previously approved these changes Aug 20, 2024
@AdiRishi AdiRishi merged commit 9a4fe22 into AdiRishi:master Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Decrease overall bundle size

3 participants