-
Notifications
You must be signed in to change notification settings - Fork 0
MergeSort Example. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
matthewhammer
wants to merge
40
commits into
main
Choose a base branch
from
mergesortExample
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhammer
commented
May 29, 2025
@@ -434,7 +438,16 @@ pub mod def { | |||
} | |||
Ok(()) | |||
} | |||
Dec::Type(_id, _typ_binds, _typ) => Ok(()), | |||
Dec::Type(_id, _typ_binds, _typ) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an unrelated effort to this PR, this change slipped in.
It's related to expanding the #[derive(XYZ)]
annotations that can appear on types in Fumola. The idea is to expand these into Fumola/Motoko functions that implement the named "traits".
Benchmark for a42f7a9Click to view benchmark
|
Benchmark for 8b097b7Click to view benchmark
|
Benchmark for ed75366Click to view benchmark
|
Benchmark for 58e9e72Click to view benchmark
|
Benchmark for 5003ebfClick to view benchmark
|
Benchmark for abf9099Click to view benchmark
|
Benchmark for c1de6a9Click to view benchmark
|
Benchmark for 49e71d8Click to view benchmark
|
…or mergesort example
Benchmark for 7236e3dClick to view benchmark
|
Benchmark for 067467aClick to view benchmark
|
Benchmark for e2addebClick to view benchmark
|
Benchmark for c362d68Click to view benchmark
|
Benchmark for 4d7e9b9Click to view benchmark
|
Benchmark for eaead13Click to view benchmark
|
Benchmark for 6829151Click to view benchmark
|
Benchmark for b2ce112Click to view benchmark
|
Benchmark for bda738eClick to view benchmark
|
Benchmark for 3a1900cClick to view benchmark
|
Benchmark for 15094b0Click to view benchmark
|
Benchmark for c7acce3Click to view benchmark
|
Benchmark for fa35300Click to view benchmark
|
Benchmark for e73f8d9Click to view benchmark
|
Benchmark for f50d9edClick to view benchmark
|
Benchmark for 171699bClick to view benchmark
|
Benchmark for af25193Click to view benchmark
|
Benchmark for daa566eClick to view benchmark
|
Benchmark for 144a5a0Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing a
mergesort
example for the Adapton Recipe Document.This PR is handling some technical debt that needs to be resolved before this example evaluates completely.
For instance, we want to iterate arrays and get their size, but those features were missing in the VM stepping logic.
This PR addresses those missing features as they come up in working toward running, and rerunning,
mergesort
on example data.