Skip to content

Conversation

matthewhammer
Copy link
Member

Writing a mergesort example for the Adapton Recipe Document.

This PR is handling some technical debt that needs to be resolved before this example evaluates completely.

For instance, we want to iterate arrays and get their size, but those features were missing in the VM stepping logic.

This PR addresses those missing features as they come up in working toward running, and rerunning, mergesort on example data.

@@ -434,7 +438,16 @@ pub mod def {
}
Ok(())
}
Dec::Type(_id, _typ_binds, _typ) => Ok(()),
Dec::Type(_id, _typ_binds, _typ) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an unrelated effort to this PR, this change slipped in.

It's related to expanding the #[derive(XYZ)] annotations that can appear on types in Fumola. The idea is to expand these into Fumola/Motoko functions that implement the named "traits".

Copy link

Benchmark for a42f7a9

Click to view benchmark
Test Base PR %
Examples/Basic example 815.3±9.22µs 797.7±10.86µs -2.16%

Copy link

Benchmark for 8b097b7

Click to view benchmark
Test Base PR %
Examples/Basic example 821.0±13.70µs 804.1±8.23µs -2.06%

Copy link

Benchmark for ed75366

Click to view benchmark
Test Base PR %
Examples/Basic example 796.1±7.44µs 800.2±10.50µs +0.52%

Copy link

Benchmark for 58e9e72

Click to view benchmark
Test Base PR %
Examples/Basic example 783.1±12.79µs 779.0±8.71µs -0.52%

Copy link

Benchmark for 5003ebf

Click to view benchmark
Test Base PR %
Examples/Basic example 783.0±17.09µs 787.1±9.85µs +0.52%

Copy link

Benchmark for abf9099

Click to view benchmark
Test Base PR %
Examples/Basic example 784.7±8.29µs 760.9±13.16µs -3.03%

Copy link

Benchmark for c1de6a9

Click to view benchmark
Test Base PR %
Examples/Basic example 780.1±11.07µs 778.2±15.68µs -0.24%

Copy link

Benchmark for 49e71d8

Click to view benchmark
Test Base PR %
Examples/Basic example 805.4±7.93µs 753.6±8.62µs -6.43%

Copy link

Benchmark for 7236e3d

Click to view benchmark
Test Base PR %
Examples/Basic example 819.3±10.89µs 770.4±8.05µs -5.97%

Copy link

github-actions bot commented Jun 2, 2025

Benchmark for 067467a

Click to view benchmark
Test Base PR %
Examples/Basic example 773.5±9.42µs 788.2±8.19µs +1.90%

Copy link

github-actions bot commented Jun 2, 2025

Benchmark for e2addeb

Click to view benchmark
Test Base PR %
Examples/Basic example 791.2±11.54µs 797.8±8.73µs +0.83%

Matthew Hammer added 2 commits June 2, 2025 13:46
Copy link

github-actions bot commented Jun 2, 2025

Benchmark for c362d68

Click to view benchmark
Test Base PR %
Examples/Basic example 786.2±20.28µs 808.4±10.05µs +2.82%

Copy link

github-actions bot commented Jun 2, 2025

Benchmark for 4d7e9b9

Click to view benchmark
Test Base PR %
Examples/Basic example 785.0±7.94µs 828.5±11.30µs +5.54%

Copy link

github-actions bot commented Jun 5, 2025

Benchmark for eaead13

Click to view benchmark
Test Base PR %
Examples/Basic example 781.4±10.41µs 791.3±7.68µs +1.27%

Copy link

github-actions bot commented Jun 5, 2025

Benchmark for 6829151

Click to view benchmark
Test Base PR %
Examples/Basic example 781.1±9.41µs 789.4±27.99µs +1.06%

Copy link

github-actions bot commented Jun 6, 2025

Benchmark for b2ce112

Click to view benchmark
Test Base PR %
Examples/Basic example 791.4±14.33µs 784.3±12.63µs -0.90%

Copy link

github-actions bot commented Jun 6, 2025

Benchmark for bda738e

Click to view benchmark
Test Base PR %
Examples/Basic example 781.3±12.35µs 789.0±8.80µs +0.99%

Copy link

github-actions bot commented Jun 6, 2025

Benchmark for 3a1900c

Click to view benchmark
Test Base PR %
Examples/Basic example 812.4±15.30µs 823.2±7.73µs +1.33%

Copy link

Benchmark for 15094b0

Click to view benchmark
Test Base PR %
Examples/Basic example 806.2±9.81µs 795.8±44.07µs -1.29%

Copy link

Benchmark for c7acce3

Click to view benchmark
Test Base PR %
Examples/Basic example 790.6±10.75µs 796.0±8.76µs +0.68%

Copy link

Benchmark for fa35300

Click to view benchmark
Test Base PR %
Examples/Basic example 816.5±8.02µs 786.5±32.64µs -3.67%

Copy link

Benchmark for e73f8d9

Click to view benchmark
Test Base PR %
Examples/Basic example 781.0±7.59µs 804.1±13.12µs +2.96%

Copy link

Benchmark for f50d9ed

Click to view benchmark
Test Base PR %
Examples/Basic example 790.0±7.48µs 770.7±13.67µs -2.44%

Matthew Hammer and others added 3 commits June 14, 2025 12:01
Copy link

Benchmark for 171699b

Click to view benchmark
Test Base PR %
Examples/Basic example 827.0±9.19µs 795.9±8.54µs -3.76%

Copy link

Benchmark for af25193

Click to view benchmark
Test Base PR %
Examples/Basic example 793.5±8.40µs 785.1±13.07µs -1.06%

Copy link

github-actions bot commented Jul 3, 2025

Benchmark for daa566e

Click to view benchmark
Test Base PR %
Examples/Basic example 800.3±14.56µs 787.1±24.47µs -1.65%

Copy link

github-actions bot commented Jul 3, 2025

Benchmark for 144a5a0

Click to view benchmark
Test Base PR %
Examples/Basic example 803.6±9.81µs 802.2±17.21µs -0.17%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant