Remove rez.utils.py23 and cleanup more python 2.7 leftovers #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanChristopheMorinPerso
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Thanks again @wandth. I left two small comments. It should hopefully be the last comments.
(you can push new commits to this pull request instead of closing and opening new pull requests to address my comments).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1678 +/- ##
==========================================
+ Coverage 58.03% 58.05% +0.01%
==========================================
Files 127 126 -1
Lines 17069 17035 -34
Branches 3496 3490 -6
==========================================
- Hits 9906 9889 -17
+ Misses 6496 6482 -14
+ Partials 667 664 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: wwn <[email protected]>
Signed-off-by: wwn <[email protected]>
Signed-off-by: wwn <[email protected]>
Signed-off-by: wwn <[email protected]>
Signed-off-by: wwn <[email protected]>
Signed-off-by: wwn <[email protected]>
JeanChristopheMorinPerso
approved these changes
Mar 8, 2024
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
changed the title
Pixel-Minions
added a commit
to Pixel-Minions/rez
that referenced
this pull request
Sep 26, 2024
…oftwareFoundation#1678) * remove rez.utils.py23 module * remove some more __nonzero__ methods --------- Signed-off-by: wwn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1646