Remove iex_debugTrap() function #2151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an ancient utility function that at one point served as a debugging aide, a symbol to set a breakpoint for in the debugger. It's problematic because it's not namespaced so it can lead to symbol collisions when linking multiple versions of the library into a single binary. This is an API change, so it should only go into the next major release. Signed-off-by: Cary Phillips <[email protected]>
|
@meshula, OK with you? We discussed this a while back but never followed up. And it does appear to be your 20+ year old code ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ancient utility function that at one point served as a debugging aide. It's problematic because it's not namespaced so it can lead to symbol collisions when linking multiple versions of the library into a single binary.
This is an API change, so it should only go into the next major release.