Updates for better HdStorm compatibility #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torm they don't conflict. Add MetalTexture methods for storm compatibility
5 tasks
|
This looks good to me, thanks @ld-kerley, and I'm CC'ing @klucknav for her thoughts on the Storm side. |
|
I should have mentioned in the original PR message - this is related to this PR on the OpenUSD side that was reported recently regarding MatX 1.39.2 not working with OpenUSD 25.02 |
jstone-lucasfilm
approved these changes
Feb 6, 2025
jstone-lucasfilm
merged commit e5adb78
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard the mx_math.metal calls to the metal:: namespace to ensure in HdStorm they don't conflict with other functions declared.
Add MetalTexture methods for storm compatibility