-
Notifications
You must be signed in to change notification settings - Fork 408
Open
Description
Issue
MaterialX's usage of PugiXML allows invalid XML to not be caught on read.
- There is an option to disallow unescaped characters.
- For MaterialX parser this appears to be off by default. Thus allowing characters like
&. - When turned off it will read unescaped characters but on write will escape them. i.e. it does not preserve breaking XML.
- MaterialX has a modified version of
PugiXMLwhich also allowed<explicitly to support UDIM syntax. This will always break XML validation even on write.
Proposed Implementation Changes
Suggested Implementation change:
- Add the escape option in. Leave it off by default to preserve current behaviour.
- Turn on by default for next desired release for read. Write is not affected since it always escapes.
Proposed Test Changes
Suggested process sanity check change:
- Run all files through read / write per release.
- Run check for all new / modified files.
Note that this does not affect UDIM logic which allows "<" and ">" when it's not a UDIM string.
Metadata
Metadata
Assignees
Labels
No labels