I think this is all that's needed #7
Conversation
|
Is the action failing here because it is currently unsupported or is there something else going on? |
|
My guess is that those symbols are only available in the beta version of 3.13 onwards, while CI is still using an alpha version. I can at least verify that it doesn't work on 3.13.0a6 on my machine, providing a similar message. |
|
Was added after alpha1, but before beta1: python/cpython#116882 CI needs to be updated I guess, idk if that should be part of the same pull or not, I can do that one way or another. |
|
Happy to discuss a bit more, but if you could rebase from |
|
rebased over main, but this likely shouldn't be merged until it can be confirmed that this will build properly under the free-threaded builds, which CIBW won't support until beta2
|
|
Looks like pypa/cibuildwheel#1854 was merged and I updated to include that. This should be good to merge now if you're happy with it? |
|
should be fine from everything I'm aware of for this. |
|
I'm stuck in Pamac on Manjaro trying to update Here’s the full error message: building 'audioop._audioop' extension creating build/temp.linux-x86_64-cpython-312/audioop gcc -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto -ffat-lto-objects -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -flto=auto -fPIC -DPy_LIMITED_API=0x030D0000 -I/usr/include/python3.12 -c audioop/_audioop.c -o build/temp.linux-x86_64-cpython-312/audioop/_audioop.o audioop/_audioop.c:1984:6: erreur: « Py_mod_gil » non déclaré ici (hors de toute fonction) 1984 | {Py_mod_gil, Py_MOD_GIL_NOT_USED}, | ^~ audioop/_audioop.c:1984:18: erreur: « Py_MOD_GIL_NOT_USED » non déclaré ici (hors de toute fonction) 1984 | {Py_mod_gil, Py_MOD_GIL_NOT_USED}, | ^~~ error: command '/usr/bin/gcc' failed with exit code 1 ERROR Backend subprocess exited when trying to invoke build_wheel ==> ERREUR : Une erreur s’est produite dans build(). Abandon… |
|
This package is not needed on 3.12, audioop is still present in the python
stdlib.
…On Fri, 27 Dec 2024, 05:35 SON, ***@***.***> wrote:
I'm stuck in Pamac on Manjaro trying to update python-speechrecognition
(from version 3.12.0-1 to 3.12.0-2). The build process fails with an error
in the file _audioop.c at *line 1984*.
Here’s the full error message:
building 'audioop._audioop' extension creating
build/temp.linux-x86_64-cpython-312/audioop gcc -fno-strict-overflow
-Wsign-compare -DNDEBUG -g -O3 -Wall -march=x86-64 -mtune=generic -O3 -pipe
-fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat
-Werror=format-security -fstack-clash-protection -fcf-protection
-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g
-ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto
-ffat-lto-objects -march=x86-64 -mtune=generic -O3 -pipe -fno-plt
-fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security
-fstack-clash-protection -fcf-protection -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer -g
-ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto
-march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions
-Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security
-fstack-clash-protection -fcf-protection -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer -g
-ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto
-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
-Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security
-fstack-clash-protection -fcf-protection -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer -flto=auto -fPIC -DPy_LIMITED_API=0x030D0000
-I/usr/include/python3.12 -c audioop/_audioop.c -o
build/temp.linux-x86_64-cpython-312/audioop/_audioop.o
audioop/_audioop.c:1984:6: erreur: « Py_mod_gil » non déclaré ici (hors de
toute fonction) 1984 | {Py_mod_gil, Py_MOD_GIL_NOT_USED}, | ^~
audioop/_audioop.c:1984:18: erreur: « Py_MOD_GIL_NOT_USED » non déclaré ici
(hors de toute fonction) 1984 | {Py_mod_gil, Py_MOD_GIL_NOT_USED}, | ^~~
error: command '/usr/bin/gcc' failed with exit code 1
ERROR Backend subprocess exited when trying to invoke build_wheel ==>
ERREUR : Une erreur s’est produite dans build(). Abandon…
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2J7ZHGHXBV57V2UOMAGVD2HTRKVAVCNFSM6AAAAABUIEDC7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRTGMZTOOJVGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
So, I guess it will be necessary in 3.13 then. Should I wait to update Python to 3.13 to build audioop without errors in Pamac? |
Yes. |
4 participants
I need to double-check a few things later, but conceptually, this should be all that's needed since this already wasn't manually manipulating the GIL or relying on it implicitly.Should be ready to go, wheel built fine and imported fine on beta 1 on linux, and there shouldn't be anything platform specific about this.