Skip to content

Fix Mark Command #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 24, 2024
Merged

Fix Mark Command #144

merged 8 commits into from
Oct 24, 2024

Conversation

Timenikhil
Copy link

@Timenikhil Timenikhil commented Oct 24, 2024 •
edited
Loading

Mark Command

  1. Fixes Mark Command to update UI proactively, instead of lazily
  2. Refactor old constructors
  3. update documentation

Related Issues

@Timenikhil Timenikhil added type.Bug A bug severity.High A flaw that affects most users and causes major problems for users. priority.High Must do labels Oct 24, 2024
@Timenikhil Timenikhil self-assigned this Oct 24, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...n/java/seedu/edulog/model/util/SampleDataUtil.java 0.00% 6 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/edulog/model/EduLog.java 90.16% <100.00%> (+1.48%) 23.00 <0.00> (+2.00)
.../main/java/seedu/edulog/model/student/Student.java 93.75% <ø> (+16.16%) 23.00 <0.00> (ø)
src/main/java/seedu/edulog/ui/StudentCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...n/java/seedu/edulog/model/util/SampleDataUtil.java 14.28% <0.00%> (ø) 1.00 <0.00> (ø)

nathanshew
nathanshew requested changes Oct 24, 2024
View reviewed changes
src/main/java/seedu/edulog/model/student/Student.java Outdated

/**
* New constructor with Fee
* Every field must be present and not null except isPresent.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be hasPaid

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you I will correct it

nathanshew
nathanshew approved these changes Oct 24, 2024
View reviewed changes
Copy link

@nathanshew nathanshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanshew nathanshew merged commit fddd47e into AY2425S1-CS2103T-W09-2:master Oct 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanshew nathanshew nathanshew approved these changes

@tlim8772 tlim8772 Awaiting requested review from tlim8772

@kimxw kimxw Awaiting requested review from kimxw

Assignees

@Timenikhil Timenikhil

Labels
priority.High Must do severity.High A flaw that affects most users and causes major problems for users. type.Bug A bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update UI Deprecate and remove old Student Constructor Fix Mark Command
2 participants
@Timenikhil @nathanshew