Add fee #141
Merged
Add fee #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timenikhil
approved these changes
Oct 24, 2024
| @@ -46,6 +46,8 @@ public static String format(Student student) { | |||
| .append(student.getAddress()) | |||
| .append("; Tags: "); | |||
| student.getTags().forEach(builder::append); | |||
| builder.append("; fee ").append(student.getFee()); | |||
| @@ -96,13 +101,21 @@ public StudentBuilder withEmail(String email) { | |||
| /** | |||
| * Sets the {@code hasPaid} of the {@code Student} that we are building. | |||
| */ | |||
| public StudentBuilder withhasPaid(boolean hasPaid) { | |||
| public StudentBuilder withHasPaid(boolean hasPaid) { | |||
| @@ -31,6 +31,7 @@ | |||
| <Label fx:id="phone" styleClass="cell_small_label" text="\$phone" /> | |||
| <Label fx:id="address" styleClass="cell_small_label" text="\$address" /> | |||
| <Label fx:id="email" styleClass="cell_small_label" text="\$email" /> | |||
| <Label fx:id="fee" styleClass="cell_small_label" text="\$fee" /> | |||
|
|
||
| /** | ||
| * Every field must be present and not null except isPresent. | ||
| * Every field must be present and not null except isPresent. I suggest |
| throw new IllegalValueException(Fee.MESSAGE_CONSTRAINTS); | ||
| } | ||
| Fee modelFee = new Fee(fee); | ||
| return new Student(modelName, modelPhone, modelEmail, modelAddress, modelTags, modelFee); |
Timenikhil
merged commit afc02ea
into
AY2425S1-CS2103T-W09-2:master
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fee, need to change a lot of things 😢