Skip to content

Change to paid #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 23, 2024
Merged

Change to paid #137

merged 4 commits into from
Oct 23, 2024

Conversation

nathanshew
Copy link

No description provided.

@nathanshew nathanshew requested a review from Timenikhil October 23, 2024 12:28
@nathanshew nathanshew self-assigned this Oct 23, 2024
@nathanshew nathanshew added the priority.High Must do label Oct 23, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../main/java/seedu/edulog/model/student/Student.java 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...va/seedu/edulog/logic/commands/MarkAllCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
.../java/seedu/edulog/logic/commands/MarkCommand.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../seedu/edulog/logic/commands/MarkIndexCommand.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
.../seedu/edulog/logic/commands/UnmarkAllCommand.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...ava/seedu/edulog/logic/commands/UnmarkCommand.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...eedu/edulog/logic/commands/UnmarkIndexCommand.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...seedu/edulog/logic/commands/UnmarkNameCommand.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
src/main/java/seedu/edulog/model/EduLog.java 88.67% <ø> (ø) 21.00 <0.00> (ø)
src/main/java/seedu/edulog/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/edulog/model/ModelManager.java 97.22% <ø> (ø) 32.00 <0.00> (ø)
... and 1 more

kimxw
kimxw reviewed Oct 23, 2024
View reviewed changes
Copy link

@kimxw kimxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Thanks for changing the documentation as well
Will wait for @obrona to approve

tlim8772
tlim8772 approved these changes Oct 23, 2024
View reviewed changes
Copy link

@tlim8772 tlim8772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimxw kimxw merged commit 14b3275 into AY2425S1-CS2103T-W09-2:master Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimxw kimxw kimxw left review comments

@tlim8772 tlim8772 tlim8772 approved these changes

@Timenikhil Timenikhil Awaiting requested review from Timenikhil

Assignees

@nathanshew nathanshew

Labels
priority.High Must do
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanshew @tlim8772 @kimxw