Skip to content

Conversation

@w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented May 18, 2024

Description

changes

  • use apply_override for Clip skip
  • use override for uni_pc_order
  • use override of sd_vae
  • remove unused code

some axis is implemented using direct setting modification
but all these are not settings that are particularly special that happens in the early stages of the pipeline so override settings does work
so no reason to not switch to override is as it is more consistent as override has a higher priority
and has the benefit of simplified code as we don't need to re-implement the restoration of originating

higher priority as in for example clip, is is possible to forgot you have a override setting set in the UI that changes the clip
if you did not remove the setting then the override on the setting will have priority over the xyz axis

functionally nothing has changed aside from Automatic vae choices

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner May 18, 2024 21:02
@w-e-w w-e-w force-pushed the xyz-override-rework branch from cd49f15 to 51e7122 Compare May 19, 2024 06:40
@AUTOMATIC1111 AUTOMATIC1111 merged commit cbac72d into dev Jun 8, 2024
@AUTOMATIC1111 AUTOMATIC1111 deleted the xyz-override-rework branch June 8, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants