Skip to content

Soften Spandrel model-architecture check to just a warning #14473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2023
Merged

Soften Spandrel model-architecture check to just a warning #14473

merged 1 commit into from
Dec 30, 2023

Conversation

akx
Copy link
Collaborator

@akx akx commented Dec 30, 2023

Description

As reported by @w-e-w, RealESRGAN_x4plus.pth doesn't work post #14425 since it's identified as just ESRGAN.

Upscaling inference does work nevertheless though, so this softens the TypeError to a log warning (and makes it better).

Checklist:

@akx akx requested a review from AUTOMATIC1111 as a code owner December 30, 2023 19:07
@AUTOMATIC1111 AUTOMATIC1111 merged commit a86f441 into AUTOMATIC1111:dev Dec 30, 2023
@akx akx mentioned this pull request Dec 30, 2023
Merged
4 tasks
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
Closed
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @AUTOMATIC1111