Skip to content

Conversation

@wfjsw
Copy link
Contributor

@wfjsw wfjsw commented Nov 23, 2023

Rationale behind this change

  • If users are using insteadOf git config directive, the entire installed tag will bork as no remote url will match that in the index.
  • Even though with the situation where the remote url may be different for an already installed extension (forks), users are expected to fail later for AssertionError: Extension directory already exists
  • The original implementation, however, does cover the case where an extension is installed with a non-default folder name. But most of these cases are unlikely to have git enabled (say "Download ZIP") so there will be no remote field anyway.

Checklist:

@wfjsw wfjsw requested a review from AUTOMATIC1111 as a code owner November 23, 2023 04:49
@AUTOMATIC1111
Copy link
Owner

Maybe combine both? An extension is installed if either the remote matches or the directory name.

@wfjsw
Copy link
Contributor Author

wfjsw commented Nov 26, 2023

Maybe combine both? An extension is installed if either the remote matches or the directory name.

Sure. That could be better.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 87d973e into AUTOMATIC1111:dev Dec 2, 2023
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants