Skip to content

[feature-wisun] Updating mbed-mesh-api. #13453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 20, 2020
Merged

[feature-wisun] Updating mbed-mesh-api. #13453

merged 3 commits into from
Aug 20, 2020

Conversation

debdeep-arm
Copy link
Contributor

Summary of changes

Adding new parameters for Wi-SUN and Border router interface information.

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @mikaleppanen @artokin

@debdeep-arm
Copy link
Contributor Author

This PR has a dependency on PR13444

@debdeep-arm debdeep-arm changed the title Updating mbed-mesh-api. [feature-wisun] Updating mbed-mesh-api. Aug 18, 2020
@ciarmcom ciarmcom requested review from artokin, mikaleppanen, mikter and a team August 18, 2020 11:30
@ciarmcom
Copy link
Member

@debdeep-arm, thank you for your changes.
@mikter @mikaleppanen @artokin @ARMmbed/mbed-os-maintainers please review.

mikter
mikter reviewed Aug 18, 2020
View reviewed changes
mikter
mikter reviewed Aug 18, 2020
View reviewed changes
mikter
mikter reviewed Aug 18, 2020
View reviewed changes
@debdeep-arm debdeep-arm requested a review from mikter August 18, 2020 13:11
artokin
artokin reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@artokin artokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor typo noticed.

mikter
mikter previously approved these changes Aug 18, 2020
View reviewed changes
@debdeep-arm
Updating mbed-mesh-api.
80c9b27 
-Adding new parameters for Wi-SUN interface information.
@debdeep-arm
Resolving comments
2b11de8
@debdeep-arm
Typo fixed.
0e64f7d
@debdeep-arm debdeep-arm force-pushed the update-mbed-mesh-api branch from 11b4a48 to 0e64f7d Compare August 19, 2020 09:55
@mergify mergify bot dismissed mikter’s stale review August 19, 2020 09:56

Pull request has been modified.

@debdeep-arm debdeep-arm requested review from artokin and mikter August 19, 2020 12:54
@mergify mergify bot added needs: CI and removed needs: work labels Aug 19, 2020
@artokin
Copy link
Contributor

artokin commented Aug 20, 2020

@0xc0170 , would you please start CI run for this PR?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 20, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@artokin artokin merged commit 3036b39 into ARMmbed:feature-wisun Aug 20, 2020
@mergify mergify bot removed the ready for merge label Aug 20, 2020
This was referenced Aug 26, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikter mikter mikter approved these changes

+2 more reviewers

@artokin artokin artokin approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@debdeep-arm @ciarmcom @artokin @0xc0170 @mbed-ci @mikter @mikaleppanen