-
Notifications
You must be signed in to change notification settings - Fork 7
High gain scattering curve fit fixed, process_psds(): some units were wrong, added total scatteing mass to returned xarray + v1 of DataEditor #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…. MassIncand2total and MassIncand had different discriptions although the data is the same. Not sure why there are two names for the same data
…ween scattering low gain and high gain if the signal is large enough.
|
Scattering low gain _gaussian_sat_fit() was not working properly. Some units were wrong in the xarray attributed process_psds() and added total scattering mass to the returned xarray. Added check to ensure that the number of successful high gain and low gain scattering curve fits should be the same; under certain limits. |
…t() which is faster for ScatNumEnsembleBC, ScatNumEnsemble ScatMassEnsemble IncanNumEnsemble and IncanMassEnsemble.
| @@ -0,0 +1,114 @@ | |||
| from matplotlib import dates | |||
| from matplotlib.backend_bases import MouseButton | |||
| import numpy as np | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to eventually move this functionality to HoloViews so we can edit data via Jupyter Notebook interactively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a great idea! Didn't know about HoloViews. Looks like it's the right tool for the job.
|
Good catch on these changes! Getting SciPy's curve fit to work correctly with some of the data is a challenge, so glad you were able to get it working better! |
First version of a DataEditor that can be used to edit out bad data from a concentration time series.