Skip to content

Conversation

@johbackm
Copy link
Contributor

@johbackm johbackm commented Feb 7, 2023

First version of a DataEditor that can be used to edit out bad data from a concentration time series.

@johbackm
Copy link
Contributor Author

Scattering low gain _gaussian_sat_fit() was not working properly. Some units were wrong in the xarray attributed process_psds() and added total scattering mass to the returned xarray. Added check to ensure that the number of successful high gain and low gain scattering curve fits should be the same; under certain limits.

@johbackm johbackm changed the title DataEditor + num_bins units in microns and added to xarray coordinates in process_psds() High gain scattering curve fit fixed, process_psds(): some units were wrong, added total scatteing mass to returned xarray + v1 of DataEditor Feb 17, 2023
@@ -0,0 +1,114 @@
from matplotlib import dates
from matplotlib.backend_bases import MouseButton
import numpy as np
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to eventually move this functionality to HoloViews so we can edit data via Jupyter Notebook interactively.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great idea! Didn't know about HoloViews. Looks like it's the right tool for the job.

@rcjackson
Copy link
Collaborator

Good catch on these changes! Getting SciPy's curve fit to work correctly with some of the data is a challenge, so glad you were able to get it working better!

@rcjackson rcjackson merged commit 3f38107 into ARM-DOE:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants