-
Notifications
You must be signed in to change notification settings - Fork 7
Small fixes. #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes. #35
Conversation
…s nothing more than removing 'Time' from the DataSet.
…trs was counted twice making the total number concentration of such particles too large.
|
I approve of these changes. In the history I noticed that you had a DataEditor feature @johbackm ? If you are comfortable putting that in as a pull request on its own I think something like that would be a great contribution to PySP2. We can work together on getting that in to have an interface to manually clean out bad data. I have experimented with using bokeh to make a web-based interface to view particle waves, so perhaps we can even work together on getting your idea into PySP2. |
|
Thanks for the approval @rcjackson! Yes, I had a DataEditor in there which was not that refined. Sure, I can put that in the next pull request to see what you think. It is just a simple class to edit out data from a matplotlib figure which is quite fast when using matplotlib's own interactive navigation buttons to zoom and pan. It saves the date rage of the bad data which can then be applied to other variables. I've mainly edited concentrations but it would be good to have it work on size distributions as well. |
No description provided.