Skip to content

Conversation

@johbackm
Copy link
Contributor

No description provided.

@rcjackson
Copy link
Collaborator

I approve of these changes. In the history I noticed that you had a DataEditor feature @johbackm ? If you are comfortable putting that in as a pull request on its own I think something like that would be a great contribution to PySP2. We can work together on getting that in to have an interface to manually clean out bad data.

I have experimented with using bokeh to make a web-based interface to view particle waves, so perhaps we can even work together on getting your idea into PySP2.

@rcjackson rcjackson merged commit cb8f0e7 into ARM-DOE:main Jan 31, 2023
@johbackm
Copy link
Contributor Author

johbackm commented Feb 2, 2023

Thanks for the approval @rcjackson! Yes, I had a DataEditor in there which was not that refined. Sure, I can put that in the next pull request to see what you think. It is just a simple class to edit out data from a matplotlib figure which is quite fast when using matplotlib's own interactive navigation buttons to zoom and pan. It saves the date rage of the bad data which can then be applied to other variables. I've mainly edited concentrations but it would be good to have it work on size distributions as well.
I also have a function for removing bad particle data based on housekeeping data which could be useful for others. Not sure where to stick that function though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants