Skip to content

Conversation

@VincentCATILLON
Copy link

@VincentCATILLON VincentCATILLON commented Feb 5, 2019

Description

This PR adds custom activity indicator override to be able to use a custom spinner instead of the default one provided by React Native.

It also fixes #79.

Result and observation

You should be able to use your custom loader (a Text component in Example folder)

iOS:

capture d ecran 2019-02-05 a 23 41 33

Android:

capture d ecran 2019-02-05 a 23 42 43

How to test?

Use Button.js example which provides the new prop

@VincentCATILLON
Copy link
Author

@alvaromb Can you take a look at my PR ? :)

@VincentCATILLON
Copy link
Author

@alvaromb ?

@a-morenovalls
Copy link
Collaborator

Hey @VincentCATILLON thanks for your PR, I will take a look, but please it's not necessary to mention all APSL team ;)

@a-morenovalls a-morenovalls self-assigned this Nov 18, 2019
@SeanningTatum
Copy link

SeanningTatum commented Apr 13, 2021

Wondering when this is going to be merged, all my jest tests are broken now after installing the library.

@VincentCATILLON
Copy link
Author

3y after, nobody took a look. I'm closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests are broken and can't be run

3 participants