ENH: Add polar decomposition and convergence monitoring. #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnava
reviewed
Jun 18, 2025
tests/test_utils.py
Outdated
| # c. Check if the estimated orthogonal part is close to the known one. | ||
| nptest.assert_almost_equal(Z_known, Z_est) | ||
|
|
||
| def test_onvergence_monitoring(self): |
cookpa
reviewed
Jun 18, 2025
| # 1. Setup: Create a matrix from a known P and Z. | ||
| # The key is to multiply them in the order P @ Z. | ||
| P_known = make_known_scaling_matrix(2.5, 1.0, 1.5) | ||
| Z_known = make_known_rotation(45) # Use Z for "orthogonal" part |
There was a problem hiding this comment.
Would recommend making the rotation not 45 degrees so that the ground truth is not symmetric
There was a problem hiding this comment.
Sure, I can add this in a subsequent pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#818