Strip "v" prefix from version for find_package #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
added
bug
3 tasks
EZoni
force-pushed
the
dependencies_version_tag_v
branch
from
4f00cf3 to
da363f0
Compare
EZoni
force-pushed
the
dependencies_version_tag_v
branch
from
da363f0 to
96b23c5
Compare
EZoni
changed the title
Member
Author
|
Do you think this will work if we add it as a patch to conda-forge/pyamrex-feedstock#52? |
2 tasks
Member
|
I think it will. |
WeiqunZhang
approved these changes
Oct 2, 2025
EZoni
added a commit
to regro-cf-autotick-bot/pyamrex-feedstock
that referenced
this pull request
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow this fails in the builds for the conda-forge feedstock with
However, it doesn't fail in local builds, which is why I didn't catch it before the 25.10 release.
I will need to add this as a patch to conda-forge/pyamrex-feedstock#52.