Skip to content

Conversation

JhanSrbinovsky
Copy link
Collaborator

@JhanSrbinovsky JhanSrbinovsky commented Oct 7, 2025

First build PR#148-1 - build from pre any specific land changes associated with Aus PFTs PR#129

PR148-2 builds from the head of the main branch as at Oct 7. (a29dc8b934a20872a400a3730d36fb52cff8b37d)

Both versions use:

payu clone [email protected]:ACCESS-NRI/access-esm1.6-configs.git -B test-PIspinup-Sept-C

runs on gadi:

PR#148-1 -> GPP-148-1 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-148-GPP-6602d
PR#148-2 -> GPP-148-2 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-148-GPP-a29dc

Sept spin up configs used in both ARE seemingly ok EXCEPT the earlier 148-1 does not have the code changes neccessary to deal with the ocean albedo parameter in the namelist, input_atm.nml. Therefore the line is removed in the 148-1 config and for consistency in the 148-2 run it is set to 1


🚀 The latest prerelease access-esm1p6/pr148-2 at 1b2ab93 is here: #148 (comment) 🚀


🚀 The latest prerelease access-esm1p6/pr148-11 at 1f69710 is here: #148 (comment) 🚀

@JhanSrbinovsky JhanSrbinovsky self-assigned this Oct 7, 2025
@JhanSrbinovsky JhanSrbinovsky linked an issue Oct 7, 2025 that may be closed by this pull request
@JhanSrbinovsky JhanSrbinovsky changed the title build from pre any specific land changes associated with PR#129 build from pre any specific land changes associated with Aus PFTs Oct 7, 2025
Copy link

github-actions bot commented Oct 7, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-1 with commit 35a239e

🖥️ Gadi Deployment ✔️

Usage Instructions

access-esm1.6, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.09.002 as a Release (when merged).
  • pr148-1 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr148-1

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr148-1 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

Copy link

github-actions bot commented Oct 7, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-2 with commit 1b2ab93

🖥️ Gadi Deployment ✔️

Usage Instructions

access-esm1.6, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.09.002 as a Release (when merged).
  • pr148-2 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr148-2

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr148-2 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@JhanSrbinovsky
Copy link
Collaborator Author

JhanSrbinovsky commented Oct 7, 2025

PR#148-3 -> GPP-148-3 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-148-3-ff752

https://github.com/ACCESS-NRI/UM7/compare/ff7529166a78427ce2d3ff2a7a0caedb64dec421..6602dadd15c190ee37c6644190f52d428bc66917

@rml599gh
Copy link

rml599gh commented Oct 7, 2025

@JhanSrbinovsky - you say in the note above that in the 148-2 test you have set the ocean albedo factor to 1, but it still appears to be 0.92 in /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-148-GPP-a29dc/atmosphere/input_atm.nml - or am I missing something?

@JhanSrbinovsky
Copy link
Collaborator Author

JhanSrbinovsky commented Oct 7, 2025

@JhanSrbinovsky - you say in the note above that in the 148-2 test you have set the ocean albedo factor to 1, but it still appears to be 0.92 in /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-148-GPP-a29dc/atmosphere/input_atm.nml - or am I missing something?

@rml599gh - bugger - I was told I didn't need to use my user scripts anymore if the appeared in the payu directory. I'll overwrite and restART

actually I think I messed it up. It must've worked in the other run where I rm-ed mention of it completely so it would run

Copy link

github-actions bot commented Oct 7, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-3 with commit a8ef344

🖥️ Gadi Deployment ✔️

Usage Instructions

access-esm1.6, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.09.002 as a Release (when merged).
  • pr148-3 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr148-3

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr148-3 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@JhanSrbinovsky
Copy link
Collaborator Author

JhanSrbinovsky commented Oct 7, 2025

PR#148-3 -> GPP-148-3 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-148-GPP-ff752

corresponds to code differences between

PR148-1 v PR148-3

Copy link

github-actions bot commented Oct 7, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-4 with commit 4f26f3e

🖥️ Gadi Deployment ✔️

Usage Instructions

access-esm1.6, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.09.002 as a Release (when merged).
  • pr148-4 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr148-4

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr148-4 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@JhanSrbinovsky
Copy link
Collaborator Author

JhanSrbinovsky commented Oct 7, 2025

PR#148-4 -> GPP-148-4 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-148-4-e4b98

corresponds to code differences between

PR148-3 v PR148-4

@JhanSrbinovsky
Copy link
Collaborator Author

PR#148-5 -> GPP-148-5 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-5-148-efcfd/

corresponds to code differences between

PR148-4 v PR148-5

Copy link

github-actions bot commented Oct 7, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-5 with commit da36fda

🖥️ Gadi Deployment ✔️

Usage Instructions

access-esm1.6, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.09.002 as a Release (when merged).
  • pr148-5 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr148-5

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr148-5 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@JhanSrbinovsky
Copy link
Collaborator Author

analysis by @rml599gh indicates difference occurs between PR148-5 and 148-2

corresponding code differences are:

Note: river routing, inland basin changes shoulder be in Claires #129-3 anyway. So test -

PR#148-6 -> GPP-148-6 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-5-148-PR129-3/

that has executable from PR129-3

Also ( assuming this shows up same changes)I will set up tests using executables including step changes. (in PM)

@JhanSrbinovsky
Copy link
Collaborator Author

@rml599gh - DOH! I skipped over the code change in the very last merge. I suspect the logic is is error leading to the NP ratio for leaves being

npleafx_coef = 1.0
everywhere. whereas it should be modified for evergreen_broadleaf, aust_mesic, aust_xeric.

As a side, at a glance npleax could be 0, crashing at npleafx_coef=NaN.

I'll test a revised LOGIC strategy in GPP-7. It won't be as succinct and pretty, but it should return the same GPP again I hope.

@rml599gh
Copy link

rml599gh commented Oct 8, 2025

@JhanSrbinovsky - not sure I follow your last comment about npleafx_coef. Having been set to 1, it should be modified in the IF (ANY ... block.

@JhanSrbinovsky
Copy link
Collaborator Author

JhanSrbinovsky commented Oct 8, 2025

@JhanSrbinovsky - not sure I follow your last comment about npleafx_coef. Having been set to 1, it should be modified in the IF (ANY ... block.

@rml599gh

I imagine the ANY should be next to the array. i.e. IF ( scalar == ANY (/ EGBL, AM, AX /)

IF ( ANY( scalar == (/ EGBL, AM, AX /) ) doesn't really make sense. ivt is never == to the array

@rml599gh
Copy link

rml599gh commented Oct 8, 2025

I don't know the syntax - but wouldn't it fail to compile if it was wrong? And I thought Claire had confirmed that her re-write of the code in the subroutine gave the same answer when we were trying to track down why the name changing gave a different answer (due to the LAI_THRESH 0.99 change).

Copy link

github-actions bot commented Oct 8, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-6 with commit 0e85216

🖥️ Gadi Deployment ❌

@JhanSrbinovsky
Copy link
Collaborator Author

perhaps not. maybe instead of nothing getting into the loop, everything was. maybe it was evaluating if any ivt(mp) is EGBL etc then do this.

What I should've said was using ANY is usually in the form of IF (scalar == ANY(array) ). which I just realize I copied/pasted and forgot to add IF ivt(np) = EGBL

There is also the problem that we are inside of a DO loop over np, so IDK what it would evaluate it as

IDK what the comparison was to?

no guarantee that this will resolve it, but its worth checking

@JhanSrbinovsky
Copy link
Collaborator Author

!redeploy

Copy link

github-actions bot commented Oct 8, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-7 with commit 0e85216

🖥️ Gadi Deployment ❌

Copy link

github-actions bot commented Oct 8, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-8 with commit a1a0643

🖥️ Gadi Deployment ❌

Copy link

github-actions bot commented Oct 8, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-9 with commit 725f051

🖥️ Gadi Deployment ✔️

Usage Instructions

access-esm1.6, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.09.002 as a Release (when merged).
  • pr148-9 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr148-9

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr148-9 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@JhanSrbinovsky
Copy link
Collaborator Author

JhanSrbinovsky commented Oct 8, 2025

PR#148-9 -> GPP-7 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-7-148/ - revised conditional

PR builds went up to 9 as I kept making syntax errors. AND mod in casa_ncdf might not be necessary here but it certainly is for FCM build which is generally how I build incrementally. I reverted to FCM build for the very reason that simple build failures here due to syntax have a 20min (at least) turn around to discover. Where as FCM build can incrementally build and reveal a typo (with better error log) within minutes.

revised conditional -

IF ( ivt == ANY (/ EGBL, AM, AX /)

IF ( ANY( ivt == (/ EGBL, AM, AX /) ) doesn't really make sense. 

Other mods there are simply formatting as it was difficult to read and be confident of indentation, nesting, etc

@rml599gh
Copy link

rml599gh commented Oct 8, 2025

@JhanSrbinovsky - looks like GPP-7 is giving identical answers to 148-2. GPP-6 (129-3) is different from previous cases. Maybe we should test a case where we go back to the original way that casa_feedback was coded and just add in Australian xeric to the original code.

@JhanSrbinovsky
Copy link
Collaborator Author

under way. skimming the differences - maybe defining the _coeff = 1 by default stands out

@JhanSrbinovsky
Copy link
Collaborator Author

PR#148-10 -> GPP-10 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-10/ - reverted casa_feedback AND updated conditional

Copy link

github-actions bot commented Oct 9, 2025

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-10 with commit f47842c

🖥️ Gadi Deployment ✔️

Usage Instructions

access-esm1.6, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.09.002 as a Release (when merged).
  • pr148-10 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr148-10

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr148-10 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@JhanSrbinovsky
Copy link
Collaborator Author

PR#148-11 -> GPP-11 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-11/ - move initialization of _coef to inside DO loop

Copy link

🚀 Attempted to deploy access-esm1p6 Prerelease pr148-11 with commit 1f69710

🖥️ Gadi Deployment ✔️

Usage Instructions

access-esm1.6, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.09.002 as a Release (when merged).
  • pr148-11 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr148-11

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr148-11 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@JhanSrbinovsky
Copy link
Collaborator Author

PR#148-11 -> GPP-12 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-12/ - use code as in PR148-11 WITH 100%albedo.

If the new formulation is successfully a mere refactoring of the original code (moving the initialization of xnpleaf_coef inside the DO loop) then results from this run should match GPP-10

@JhanSrbinovsky
Copy link
Collaborator Author

PR#148-11 -> GPP-13 at /g/data/p66/jxs599/ESM16/PAYU/Feat/feat-GPP-13/ - same as GPP-12 EXCEPT start from restart270 (Sept-B)

@access-hive-bot
Copy link

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/esm1-6-spin-up-experiments/4219/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test unexpected changes in GPP

3 participants