Skip to content

Support CombinatorialMemberData for IEnumerable<string> #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

siewers
Copy link
Contributor

@siewers siewers commented Oct 28, 2022

Fixes #54

@siewers
Copy link
Contributor Author

siewers commented Oct 28, 2022

I don't know why the build fails. I changed the pinned .NET SDK version to 6.0.401, which is the latest .NET 6 version. Otherwise, I couldn't get it to build locally. I don't think it's the reason it fails though.

I decided to remove the check and test for non-generic IEnumerable return types, as the next error message clearly explains the return type should implement the generic IEnumerable<T>.

Besides that, I added explicit checks for IEnumerable<T[]> and IEnumerable<IEnumerable<T>>. I'm not sure if it's strictly necessary to split it, but I don't think it hurts to be explicit and return a descriptive message about any expected common mistakes the user might make.

@siewers
Copy link
Contributor Author

siewers commented Nov 8, 2022

@AArnott I know you might be busy, but this is blocking me from using this library at the moment. Would you be able to have a look? Thanks 🙂

@AArnott
Copy link
Owner

AArnott commented Nov 9, 2022

Yes, thank you for submitting the change. I'll take a look.

@timba
Copy link

timba commented Aug 28, 2023

The latest stable version v1.5.25 doesn't include this fix. Any plans releasing it anytime soon?

@AArnott
Copy link
Owner

AArnott commented Aug 29, 2023

Published v1.6.24 to nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CombinatorialMemberData for strings does not work
3 participants