Skip to content

Conversation

AArnott
Copy link
Owner

@AArnott AArnott commented Dec 23, 2024

Closes #113

AArnott and others added 19 commits December 18, 2024 11:29
Revert "Merge pull request #319 from AArnott/betterTestingLibTemplate"
Update .NET SDK and xunit.runner.visualstudio
@AArnott AArnott requested a review from Copilot December 23, 2024 14:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated 2 comments.

Files not reviewed (6)
  • Directory.Packages.props: Language not supported
  • global.json: Language not supported
  • src/Xunit.Combinatorial/Xunit.Combinatorial.csproj: Language not supported
  • test/Xunit.Combinatorial.Tests/Xunit.Combinatorial.Tests.csproj: Language not supported
  • version.json: Language not supported
  • docfx/docs/toc.yml: Evaluated as low risk
Comments suppressed due to low confidence (1)

test/Xunit.Combinatorial.Tests/CombinatorialDataAttributeTests.cs:188

  • The 'await' keyword should be used properly to ensure asynchronous operations are handled correctly.
private static async Task AssertData(IReadOnlyCollection<object?[]> expectedCombinatorial, [CallerMemberName] string? testMethodName = null)

@AArnott AArnott enabled auto-merge December 23, 2024 14:33
@AArnott AArnott merged commit 17d97c5 into main Dec 23, 2024
3 checks passed
@AArnott AArnott deleted the xunitv3 branch December 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for xunit.v3
1 participant