feat/js bundle 참조 위치를 cdn 경로로 변경 #166
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmonco
commented
Apr 30, 2025
package.json
Outdated
Comment on lines
15
to
17
| "bundle:android": "react-native bundle --platform android --dev false --entry-file index.js --bundle-output dist/android/index.android.bundle --assets-dest dist/android/assets", | ||
| "bundle:ios": "react-native bundle --platform ios --dev false --entry-file index.js --bundle-output dist/ios/index.ios.bundle --assets-dest dist/ios/assets", | ||
| "bundle": "yarn bundle:android && yarn bundle:ios" |
There was a problem hiding this comment.
추후 js 코드 변경 시 -> yarn bundle 명령어 실행 -> dist 폴더에 추출된 js bundle 파일과 assets 를 CDN 에 업로드하는 방식입니다.
Comment on lines
+43
to
+45
| // return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"]; | ||
| // Code Push via CDN | ||
| return [NSURL URLWithString:@"https://ip-file-upload-test.s3.ap-northeast-2.amazonaws.com/naeilmorae-bundle/index.ios.bundle"]; |
There was a problem hiding this comment.
ios 에서 외부 js bundle 파일을 참조하게 했습니다.
Comment on lines
+23
to
+32
| // Code Push via CDN | ||
| override fun getJSBundleFile(): String? { | ||
| return if (BuildConfig.DEBUG) { | ||
| // 디버그 모드일 때는 null 반환해서 Metro 서버 연결 | ||
| null | ||
| } else { | ||
| // 릴리즈 모드일 때는 CDN 번들 사용 | ||
| "https://ip-file-upload-test.s3.ap-northeast-2.amazonaws.com/naeilmorae-bundle/index.android.bundle" | ||
| } | ||
| } |
There was a problem hiding this comment.
안드로이드에서 외부 js bundle 파일을 참조하게 했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 분류
요구사항
작업 내용
트러블슈팅
TODO
테스트