Skip to content

Conversation

ultwcz
Copy link
Contributor

@ultwcz ultwcz commented Aug 23, 2024

Hi,

I am Using the script to correct the improper use of "" and replace it with ''. It is great!!!.

Also, check the newly added Chinese translation.

By the way, compared to your work, mine seems quite rough.

@9001
Copy link
Owner

9001 commented Aug 23, 2024

Nice, thanks for the translation fixes! That was fast hehe

Regarding " vs' for strings, I have some good news - we don't really have to worry about those. The javascript doesn't care, since they mean the same thing. But the script is pretty dumb, and just sees that there's difference, so it complains :-)

But it's fine either way, and your changes will make the script complain less, so that's nice 😁 👍

BTW, I am adding one more string -- what should the following be in Chinese?

English: you cannot select more than one folder, nor can you mix flies and folders in one selection
Norwegian: du kan ikke markere flere mapper samtidig, eller kombinere mapper og filer

These are regarding the sharing feature, where you select the files and folders you want to share. It is OK to select either nothing, or one folder, or one or more files. This message will be displayed if you select more than one folder. Just to avoid any confusion, the meaning is that it is fine to share as many folders as you'd like, but then you need to perform the steps to create a share repeatedly, doing one folder at a time. This was a bit tricky to get right in Norwegian, so I wanted to point it out just in case.

Thanks, and have a nice weekend!

@9001 9001 merged commit 55a77c5 into 9001:hovudstraum Aug 23, 2024
@ultwcz
Copy link
Contributor Author

ultwcz commented Aug 23, 2024

Nice, thanks for the translation fixes! That was fast hehe

Regarding " vs' for strings, I have some good news - we don't really have to worry about those. The javascript doesn't care, since they mean the same thing. But the script is pretty dumb, and just sees that there's difference, so it complains :-)

But it's fine either way, and your changes will make the script complain less, so that's nice 😁 👍

BTW, I am adding one more string -- what should the following be in Chinese?

English: you cannot select more than one folder, nor can you mix flies and folders in one selection Norwegian: du kan ikke markere flere mapper samtidig, eller kombinere mapper og filer

These are regarding the sharing feature, where you select the files and folders you want to share. It is OK to select either nothing, or one folder, or one or more files. This message will be displayed if you select more than one folder. Just to avoid any confusion, the meaning is that it is fine to share as many folders as you'd like, but then you need to perform the steps to create a share repeatedly, doing one folder at a time. This was a bit tricky to get right in Norwegian, so I wanted to point it out just in case.

Thanks, and have a nice weekend!

Hi, @9001 ,
I translated it following, refering english:
English: you cannot select more than one folder, nor can you mix flies and folders in one selection
Norwegian: du kan ikke markere flere mapper samtidig, eller kombinere mapper og filer
Chinese: 你不能同时选择多个文件夹,也不能同时选择文件夹和文件

Thanks

@ultwcz ultwcz deleted the translate_fix branch August 30, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants