-
Notifications
You must be signed in to change notification settings - Fork 625
translating to Spanish #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
copyparty/web/browser.js
Outdated
"cl_favico": "favicon", | ||
"cl_bigdir": "directorios grandes", | ||
"cl_hsort": "#ordenar", | ||
"cl_keytype": "notación de teclas", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo this should be Notación musical
, cause the current translation used the wrong translation of key.
I'm not entirely sure this is the correct translation either since I don't know the right terminology in Spanish, but it's def more correct than the current translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i looked into the context of where the string is used and i would think that is a good translation, i am not fluent in music terminology nevertheless that is a better translation. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem ^^
just in case you're any better at git than I am, would you be able to rebase this? otherwise I'll keep trying and maybe eventually figure it out 😁 just keep your translation right below german so they're alphabetic if possible |
Also please change "esp" to "spa" to comply the ISO 639-2 standard 🫡 |
@9001 I think i have just rebased it correctly |
@@ -4390,7 +4390,7 @@ var Ls = { | |||
} | |||
}; | |||
|
|||
var LANGS = ["eng", "nor", "chi", "deu", "rus", "ukr", "spa"]; | |||
var LANGS = ["eng", "nor", "chi", "deu", "spa", "rus", "ukr"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R comes before S in the alphabet
@@ -94,6 +94,7 @@ var Ls = { | |||
"af1": "显示最近上传的文件", //m | |||
"ag1": "查看已知 IdP 用户", //m | |||
}, | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these necessary? if anything, i'd remove the newlines between each language block
thanks! gonna hurry and merge this because there's lots of upcoming stuff in browser.js |
PR to add Spanish language to the project. For any native Spanish speaker free to update note improvements / changes to the translation.
The translation was first made with an LLM (no code generation, just the translation) to translate the bulk of the lines, and then checked and fixed line by line (native Spanish speaker).
I have seen that the control plane cannot (or i did not find how to) be currently translated neither the headers of the grid view of the files, so those ones is kept in English.EDIT: it was incopyparty/web/splash.js
This PR complies with the DCO; https://developercertificate.org/