Skip to content

translating to Spanish #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 1, 2025
Merged

translating to Spanish #310

merged 8 commits into from
Aug 1, 2025

Conversation

herruzo99
Copy link
Contributor

@herruzo99 herruzo99 commented Jul 30, 2025

PR to add Spanish language to the project. For any native Spanish speaker free to update note improvements / changes to the translation.

The translation was first made with an LLM (no code generation, just the translation) to translate the bulk of the lines, and then checked and fixed line by line (native Spanish speaker).

I have seen that the control plane cannot (or i did not find how to) be currently translated neither the headers of the grid view of the files, so those ones is kept in English. EDIT: it was in copyparty/web/splash.js

This PR complies with the DCO; https://developercertificate.org/

"cl_favico": "favicon",
"cl_bigdir": "directorios grandes",
"cl_hsort": "#ordenar",
"cl_keytype": "notación de teclas",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo this should be Notación musical, cause the current translation used the wrong translation of key.
I'm not entirely sure this is the correct translation either since I don't know the right terminology in Spanish, but it's def more correct than the current translation

Copy link
Contributor Author

@herruzo99 herruzo99 Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i looked into the context of where the string is used and i would think that is a good translation, i am not fluent in music terminology nevertheless that is a better translation. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem ^^

@herruzo99 herruzo99 marked this pull request as ready for review July 31, 2025 08:12
@herruzo99 herruzo99 changed the title wip: translating to Spanish translating to Spanish Jul 31, 2025
@9001
Copy link
Owner

9001 commented Jul 31, 2025

just in case you're any better at git than I am, would you be able to rebase this? otherwise I'll keep trying and maybe eventually figure it out 😁 just keep your translation right below german so they're alphabetic if possible

@DairoDev
Copy link

DairoDev commented Aug 1, 2025

Also please change "esp" to "spa" to comply the ISO 639-2 standard 🫡

@herruzo99
Copy link
Contributor Author

@9001 I think i have just rebased it correctly

@@ -4390,7 +4390,7 @@ var Ls = {
}
};

var LANGS = ["eng", "nor", "chi", "deu", "rus", "ukr", "spa"];
var LANGS = ["eng", "nor", "chi", "deu", "spa", "rus", "ukr"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R comes before S in the alphabet

@@ -94,6 +94,7 @@ var Ls = {
"af1": "显示最近上传的文件", //m
"ag1": "查看已知 IdP 用户", //m
},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these necessary? if anything, i'd remove the newlines between each language block

@9001 9001 merged commit 4e8b88d into 9001:hovudstraum Aug 1, 2025
@9001
Copy link
Owner

9001 commented Aug 1, 2025

thanks! gonna hurry and merge this because there's lots of upcoming stuff in browser.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants