Skip to content

Conversation

jingchen2222
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@jingchen2222 jingchen2222 added the enhancement New feature or request label Dec 13, 2021
@jingchen2222 jingchen2222 added this to the v0.4 milestone Dec 13, 2021
@jingchen2222 jingchen2222 self-assigned this Dec 13, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021

Linux Test Report

       60 files       180 suites   35m 10s ⏱️
  9 197 tests   9 197 ✔️ 0 💤 0
13 269 runs  13 269 ✔️ 0 💤 0

Results for commit 9b48416.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021

HybridSE Linux Test Report

       71 files       237 suites   5m 24s ⏱️
18 990 tests 18 990 ✔️ 0 💤 0
19 021 runs  19 021 ✔️ 0 💤 0

Results for commit 9b48416.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021

HybridSE Mac Test Report

       71 files       237 suites   6m 25s ⏱️
18 990 tests 18 990 ✔️ 0 💤 0
19 021 runs  19 021 ✔️ 0 💤 0

Results for commit 9b48416.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #892 (9b48416) into main (63b4a43) will increase coverage by 0.01%.
The diff coverage is 98.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #892      +/-   ##
============================================
+ Coverage     83.07%   83.08%   +0.01%     
  Complexity       22       22              
============================================
  Files           283      283              
  Lines         52981    53025      +44     
  Branches         31       31              
============================================
+ Hits          44013    44055      +42     
- Misses         8959     8961       +2     
  Partials          9        9              
Impacted Files Coverage Δ
hybridse/include/node/node_manager.h 100.00% <ø> (ø)
hybridse/include/node/sql_node.h 72.34% <92.85%> (+0.19%) ⬆️
hybridse/include/node/plan_node.h 84.33% <100.00%> (+0.07%) ⬆️
hybridse/include/sdk/result_set.h 88.23% <100.00%> (ø)
hybridse/src/node/node_manager.cc 88.57% <100.00%> (ø)
hybridse/src/node/plan_node.cc 84.81% <100.00%> (+0.05%) ⬆️
hybridse/src/node/sql_node.cc 78.48% <100.00%> (-0.04%) ⬇️
hybridse/src/planv2/ast_node_converter.cc 94.05% <100.00%> (+0.10%) ⬆️
hybridse/src/planv2/ast_node_converter_test.cc 95.75% <100.00%> (+0.03%) ⬆️
hybridse/src/planv2/planner_v2_test.cc 96.26% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b4a43...9b48416. Read the comment docs.

Copy link
Collaborator

@aceforeverd aceforeverd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingchen2222 jingchen2222 merged commit 89ac2ec into 4paradigm:main Dec 15, 2021
@jingchen2222 jingchen2222 deleted the feat/set_and_show_variables branch December 15, 2021 03:51
@jingchen2222
Copy link
Collaborator Author

@lumianph lumianph mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL: support set and show session system variable and global system variable syntax and logical plan

3 participants