-
-
Couldn't load subscription status.
- Fork 216
chore: add Knip for upkeeping #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
So we don't have unit tests in the adapters section anymore, those are tested with e2e tests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
|
@webpro I get a failure when running knip in CI (and can reproduce locally) with the following conditions:
$ pnpm run lint:knip --workspace packages/nuqs
> [email protected] lint:knip /Users/franky/dev/playground/47ng/nuqs
> knip --workspace packages/nuqs
ERROR: Error loading /Users/franky/dev/playground/47ng/nuqs/packages/e2e/react-router/v6/cypress.config.ts
Reason: Cannot find module 'e2e-shared/cypress.config'
Require stack:
- /Users/franky/dev/playground/47ng/nuqs/packages/e2e/react-router/v6/cypress.config.ts
ELIFECYCLE Command failed with exit code 2.
zsh: exit 2 pnpm run lint:knip --workspace packages/nuqsRunning Is knip trying to check somewhere it shouldn't? |
|
Thanks for giving Knip a shot! There are two things relevant here:
The result is that dependencies of at least the ancestors and dependents should be installed upfront. Does that help? |
|
That makes sense, thanks for the explanation! I'll run knip on a fully-installed dependencies setup then. |
CreateStandardSchemaV1Optionstype