Skip to content

Conversation

shubhamku044
Copy link
Contributor

What

What does this pull request accomplish?

How

What code changes were made to accomplish it?

in network_bandwidth.sh file, I made a check whether uname -s is Darwin or Linux. then I added extra lines inside a if else block for Darwin

Why

  • I want to fix the issue # (issue)
  • I want to add a new feature
  • I want to improve the documentation
  • I want to fix the tests

Screenshots (If applicable)

image

Notes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@@ -2,7 +2,18 @@

INTERVAL="1" # update interval in seconds

network_name=$(tmux show-option -gqv "@tmux2k-network-bandwidth")
# Network interface to monitor
network_name="en0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the network name doesn't feel like a good idea, we can use network name passed in as an option for better usability

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I thought that in mac or any laptop, people mostly use wifi to connect to the internet, and this en0 is the wifi. But, I will change it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this in, will add the name option and docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@2KAbhishek
Copy link
Owner

2KAbhishek commented Mar 28, 2023

thanks @shubhamku044
will merge this in after the comments have been resolved

@2KAbhishek 2KAbhishek merged commit d2491d1 into 2KAbhishek:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Not getting network bandwidth in my mac m1 air
2 participants