Skip to content

Conversation

@deep-project
Copy link
Contributor

@deep-project deep-project commented Jun 16, 2023

What this PR does / why we need it?

当后端获取到的ssh日志为空时,传递到前端的data = null
data.value = res.data.logs || [];
这时候,运行到 res.data.logs时,会发生错误,导致data.value并不会更新到视图。
改成
data.value = res.data?.logs || [];
就可以了

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 16, 2023

@deep-project: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wanghe-fit2cloud after the PR has been reviewed.
You can assign the PR to them by writing /assign @wanghe-fit2cloud in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud wanghe-fit2cloud merged commit ae38239 into 1Panel-dev:dev Jun 16, 2023
@deep-project deep-project deleted the ssh_log_render branch June 21, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants