Add Bit.1.0 and LED example #59
Conversation
* Bit is a primitive type and does not have a fixed port id assigned to its usage. Therefore it needs to be implemented using templates assigning the desired subject id at compile time. * The existing implementation hard-coded serialisation/deserialisation, this is not necessary since the uavcan C headers for this type exist and can be used. * Moving Bit.1.0 to the correct spot, that is: uavcan/primitive/scalar.
…ghtmare for potential business adopters if everyone would claim copyright for a couple of files.
aentinger
left a comment
aentinger
left a comment
There was a problem hiding this comment.
Good morning @generationmake 👋 I've patched your PR up with the necessary changes, please have a look at them as I believe they will further your understanding of the UAVCAN design. Also can you please test with your setup if the LED blinky will still work?
|
@per1234 👋 ☕ Seems a problem with |
|
The "Unit Tests" workflow run failure will be fixed by arduino/cpp-test-action#3 |
|
Hi @aentinger I also made an extended example with several Subject-IDs and some LEDs and switches. I used the Bit.1.0 to publish and to subscribe. |
|
keywords needs to be updated. |
Can you do it? I won't get to it until tomorrow and after adding the keyword this PR can be merged. |
corrected pyuavcan command Co-authored-by: Pavel Kirienko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 83.43% 83.71% +0.28%
==========================================
Files 17 18 +1
Lines 513 522 +9
==========================================
+ Hits 428 437 +9
Misses 85 85
Continue to review full report at Codecov.
|
aentinger
added
topic: firmware
5 participants
I added functions for custom subjects for the area of unregulated identifiers. There is also an example which allows turn the builtin LED of the Arduino on and off using uavcan.
However there are some drawbacks with these changes: