Skip to content

Conversation

ElektroKill
Copy link
Contributor

@ElektroKill ElektroKill commented Aug 2, 2023

Implementation as described in #519

Will add the assembly full name improvements after they are greenlit over at #519.

fixes #519 (For GitHub to properly link the PR to the issue :D)

@wtfsck
Copy link
Contributor

wtfsck commented Aug 5, 2023

Will add the assembly full name improvements after they are greenlit over at #519.

Yes, you can improve that code!

@ElektroKill ElektroKill marked this pull request as ready for review August 5, 2023 11:34
Copy link
Contributor

@wtfsck wtfsck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you written assemblies to disk and compared the files before/after these changes (old dnlib vs new one) to make sure the output didn't change?

@ElektroKill
Copy link
Contributor Author

LGTM. Have you written assemblies to disk and compared the files before/after these changes (old dnlib vs new one) to make sure the output didn't change?

Yes I have

@wtfsck wtfsck merged commit d344770 into 0xd4d:master Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize properties on TypeRef and TypeDef
2 participants