Skip to content

Conversation

CreateAndInject
Copy link
Contributor

Fix #450

@ElektroKill
Copy link
Contributor

I suggest we add a additional signature compared flag to revert to the old behavior to allow easy adaptation of code from v3 to v4.

@CreateAndInject
Copy link
Contributor Author

It's useful when you open the same assembly but two different versions and need to compare defs.

We should add an option if we don't check if they are from the same module to fix above issue.

But if we already checked the module, no reason to add such option, since it just fix the bug but doesn't take any side effect, unless we can imagine an example which old code work fine but new code make wrong.

@wtfsck
Copy link
Contributor

wtfsck commented Jul 21, 2023

Yes an option to revert to the old behavior is needed.

since it just fix the bug

It's not a bug as explained in the linked issue.

@wtfsck wtfsck merged commit 8558fa7 into 0xd4d:master Jul 22, 2023
@wtfsck
Copy link
Contributor

wtfsck commented Jul 22, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does dnlib compare two MemberDef by name?
3 participants