Skip to content

Update AssemblyRef.Attributes when updating AssemblyRef.PublicKeyOrToken #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2021
Merged

Update AssemblyRef.Attributes when updating AssemblyRef.PublicKeyOrToken #437

merged 2 commits into from
Dec 28, 2021

Conversation

CreateAndInject
Copy link
Contributor

Fix #436

wtfsck
wtfsck reviewed Dec 28, 2021
View reviewed changes
wtfsck
wtfsck requested changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@wtfsck wtfsck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct fix is to fix any code that depend on that flag being set/cleared.

@CreateAndInject CreateAndInject force-pushed the UpdateAssemblyRefAttributes branch from e56ef60 to 5622549 Compare December 28, 2021 15:24
@wtfsck wtfsck merged commit 842fc46 into 0xd4d:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtfsck wtfsck wtfsck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong assembly reference
2 participants
@CreateAndInject @wtfsck