-
Notifications
You must be signed in to change notification settings - Fork 4
(consensus/params): Set default value of BlobParams.maxBytes to 0
#19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(consensus/params): Set default value of BlobParams.maxBytes to 0
#19
Conversation
sergio-mena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your patience 🙏. I know sometimes you need a good deal of it to cope with my reviews.
Only one last comment, but it's just a matter of how far we want to go with checks. Up to you if you want to address it.
APPROVE (I'm approving here, as I can't hit the "Approve" below)
Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: Sergio Mena <[email protected]>
|



As initially blobs will be disabled it makes sense to have the blob max bytes set to be 0 by default. This way, when the feature is enabled, there needs to be a governence proposal to update the max bytes to be something > 0 and < 800kb.