add min-args plugin filter

Author: zloirock

packages/core-js-babel-plugin/index.js

@@ -33,14 +33,15 @@ function resolveHint(desc, meta) {
     if (hint === $hint) return desc[hint];
     required = false;
   }
-  if (required) return desc.common;
+  return required ? desc.common : null;
 }
 
 module.exports = defineProvider(({
   createMetaResolver,
   debug,
   method,
   targets,
+  babel: { types: t },
 }, {
   pkg,
   pkgs,
@@ -88,6 +89,17 @@ module.exports = defineProvider(({
     }
   }
 
+  function filter(name, args, path) {
+    const { node, parent } = path;
+    // eslint-disable-next-line sonarjs/no-small-switch -- tba
+    switch (name) {
+      case 'min-args':
+        if (!t.isCallExpression(parent, { callee: node }) && !t.isNewExpression(parent, { callee: node })) return false;
+        if (parent.arguments.length >= args[0]) return false;
+        return parent.arguments.every(arg => !t.isSpreadElement(arg));
+    }
+  }
+
   return {
     name: 'core-js@4',
     polyfills: modulesListForTargetVersion,
@@ -97,15 +109,17 @@ module.exports = defineProvider(({
       injectCoreJSModulesForEntry(entry, utils);
       path.remove();
     },
-    usageGlobal(meta, utils) {
+    usageGlobal(meta, utils, path) {
       const resolved = resolve(meta);
       if (!resolved) return;
       let { kind, desc: { global: desc } } = resolved;
       if (kind === 'instance') {
         desc = resolveHint(desc, meta);
-        if (!desc) return true;
+        if (desc === null) return true;
       }
-      for (const entry of desc.dependencies) {
+      const { dependencies, filters } = desc;
+      if (filters?.some(([name, ...args]) => filter(name, args, path))) return true;
+      for (const entry of dependencies) {
         injectCoreJSModulesForEntry(`${ mode }/${ entry }`, utils);
       }
       return true;

packages/core-js-compat/src/built-in-definitions.mjs

@@ -1,8 +1,11 @@
-const ErrorConstructorDependencies = { global: 'error/constructor' };
+const ErrorConstructor = { global: {
+  dependencies: 'error/constructor',
+  filters: [['min-args', 2]],
+} };
 
-const ErrorStaticDependencies = { isError: 'error/is-error' };
+const ErrorStatic = { isError: 'error/is-error' };
 
-const TypedArrayStaticMethods = {
+const TypedArrayStatic = {
   from: { global: 'typed-array/from' },
   of: { global: 'typed-array/of' },
 };
@@ -15,8 +18,8 @@ export const Globals = {
   DataView: { global: 'data-view/constructor' },
   DOMException: { global: 'dom-exception/constructor' },
   DisposableStack: 'disposable-stack/constructor',
-  Error: ErrorConstructorDependencies,
-  EvalError: ErrorConstructorDependencies,
+  Error: ErrorConstructor,
+  EvalError: ErrorConstructor,
   Float32Array: 'typed-array/float32-array',
   Float64Array: 'typed-array/float64-array',
   Int8Array: 'typed-array/int8-array',
@@ -30,16 +33,16 @@ export const Globals = {
   Map: 'map/constructor',
   Number: { global: 'number/constructor' },
   Promise: 'promise/constructor',
-  RangeError: ErrorConstructorDependencies,
-  ReferenceError: ErrorConstructorDependencies,
+  RangeError: ErrorConstructor,
+  ReferenceError: ErrorConstructor,
   Reflect: undefined,
   RegExp: { global: 'regexp/constructor' },
   Set: 'set/constructor',
   SuppressedError: 'suppressed-error/constructor',
   Symbol: 'symbol/constructor',
-  SyntaxError: ErrorConstructorDependencies,
-  TypeError: ErrorConstructorDependencies,
-  URIError: ErrorConstructorDependencies,
+  SyntaxError: ErrorConstructor,
+  TypeError: ErrorConstructor,
+  URIError: ErrorConstructor,
   URL: 'url/constructor',
   URLSearchParams: 'url-search-params/constructor',
   WeakMap: 'weak-map/constructor',
@@ -70,8 +73,8 @@ export const StaticProperties = {
   ArrayBuffer: {
     isView: { global: 'array-buffer/is-view' },
   },
-  Error: ErrorStaticDependencies,
-  EvalError: ErrorStaticDependencies,
+  Error: ErrorStatic,
+  EvalError: ErrorStatic,
   Iterator: {
     concat: 'iterator/concat',
     from: 'iterator/from',
@@ -155,8 +158,8 @@ export const StaticProperties = {
     try: 'promise/try',
     withResolvers: 'promise/with-resolvers',
   },
-  RangeError: ErrorStaticDependencies,
-  ReferenceError: ErrorStaticDependencies,
+  RangeError: ErrorStatic,
+  ReferenceError: ErrorStatic,
   Reflect: {
     apply: 'reflect/apply',
     construct: 'reflect/construct',
@@ -208,9 +211,9 @@ export const StaticProperties = {
     toStringTag: 'symbol/to-string-tag',
     unscopables: 'symbol/unscopables',
   },
-  SyntaxError: ErrorStaticDependencies,
-  TypeError: ErrorStaticDependencies,
-  URIError: ErrorStaticDependencies,
+  SyntaxError: ErrorStatic,
+  TypeError: ErrorStatic,
+  URIError: ErrorStatic,
   URL: {
     canParse: 'url/can-parse',
     parse: 'url/parse',
@@ -223,23 +226,23 @@ export const StaticProperties = {
     from: 'weak-set/from',
     of: 'weak-set/of',
   },
-  Float32Array: TypedArrayStaticMethods,
-  Float64Array: TypedArrayStaticMethods,
-  Int8Array: TypedArrayStaticMethods,
-  Int16Array: TypedArrayStaticMethods,
-  Int32Array: TypedArrayStaticMethods,
+  Float32Array: TypedArrayStatic,
+  Float64Array: TypedArrayStatic,
+  Int8Array: TypedArrayStatic,
+  Int16Array: TypedArrayStatic,
+  Int32Array: TypedArrayStatic,
   Uint8Array: {
-    ...TypedArrayStaticMethods,
+    ...TypedArrayStatic,
     fromBase64: 'typed-array/from-base64',
     fromHex: 'typed-array/from-hex',
   },
-  Uint8ClampedArray: TypedArrayStaticMethods,
-  Uint16Array: TypedArrayStaticMethods,
-  Uint32Array: TypedArrayStaticMethods,
+  Uint8ClampedArray: TypedArrayStatic,
+  Uint16Array: TypedArrayStatic,
+  Uint32Array: TypedArrayStatic,
   WebAssembly: {
-    CompileError: ErrorConstructorDependencies,
-    LinkError: ErrorConstructorDependencies,
-    RuntimeError: ErrorConstructorDependencies,
+    CompileError: ErrorConstructor,
+    LinkError: ErrorConstructor,
+    RuntimeError: ErrorConstructor,
   },
 };
 

scripts/build-entries/entries-definitions.mjs

@@ -889,7 +889,7 @@ export const features = {
     template: $path,
   },
   'error/constructor': {
-    modules: [/^(?:es|esnext)\.error\./],
+    modules: ['es.error.cause'],
     template: $path, // !!!!!!!
   },
   'error/is-error': {

tests/babel-plugin/fixtures/usage-global/error-call-1/input.mjs

@@ -0,0 +1 @@
+Error(msg);

tests/babel-plugin/fixtures/usage-global/error-call-1/options.json

@@ -0,0 +1,14 @@
+{
+  "plugins": [
+    [
+      "@core-js",
+      {
+        "method": "usage-global",
+        "version": "4.0",
+        "targets": {
+          "ie": 11
+        }
+      }
+    ]
+  ]
+}

tests/babel-plugin/fixtures/usage-global/error-call-1/output.mjs

@@ -0,0 +1 @@
+Error(msg);

tests/babel-plugin/fixtures/usage-global/error-call-2/input.mjs

@@ -0,0 +1 @@
+Error(msg, opts);

tests/babel-plugin/fixtures/usage-global/error-call-2/options.json

@@ -0,0 +1,14 @@
+{
+  "plugins": [
+    [
+      "@core-js",
+      {
+        "method": "usage-global",
+        "version": "4.0",
+        "targets": {
+          "ie": 11
+        }
+      }
+    ]
+  ]
+}

tests/babel-plugin/fixtures/usage-global/error-call-2/output.mjs

@@ -0,0 +1,2 @@
+import "core-js/modules/es.error.cause";
+Error(msg, opts);

tests/babel-plugin/fixtures/usage-global/error-new-1/input.mjs

@@ -0,0 +1 @@
+new Error(msg);