Skip to content

Commit 2002f5f

Browse files
committed
fix: apply clippy suggestions to circom.rs
Remove unused imports and fix code quality issues: - Remove unused js_sys::Number import - Remove unused extract_substr_idxes import - Fix unnecessary clone on Copy type (ProvingFramework) - Change &Vec<RegexPart> to &[RegexPart] for better idiomatic Rust - Remove redundant clone() in regex_parts_serde serialization This reduces compiler warnings and improves code quality.
1 parent afc6b56 commit 2002f5f

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/circuit/circom.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
use anyhow::Result;
2-
use js_sys::Number;
32
use serde::{Deserialize, Serialize};
43
use serde_json::{json, Value};
54
use std::collections::VecDeque;
65
use crate::regex::{
7-
extract_substr_idxes,
86
DecomposedRegexConfig, RegexPart,
97
};
108
use zk_regex_compiler::{gen_circuit_inputs, NFAGraph, ProverInputs, ProvingFramework};
@@ -132,7 +130,7 @@ impl Clone for DecomposedRegex {
132130
max_haystack_length: self.max_haystack_length,
133131
haystack_location: self.haystack_location.clone(),
134132
regex_graph_json: self.regex_graph_json.clone(),
135-
proving_framework: self.proving_framework.clone(),
133+
proving_framework: self.proving_framework,
136134
}
137135
}
138136
}
@@ -142,11 +140,11 @@ mod regex_parts_serde {
142140
use super::*;
143141
use serde::{Deserializer, Serializer};
144142

145-
pub fn serialize<S>(parts: &Vec<RegexPart>, serializer: S) -> Result<S::Ok, S::Error>
143+
pub fn serialize<S>(parts: &[RegexPart], serializer: S) -> Result<S::Ok, S::Error>
146144
where
147145
S: Serializer,
148146
{
149-
let serializable: Vec<SerializableRegexPart> = parts.iter().map(|p| p.clone().into()).collect();
147+
let serializable: Vec<SerializableRegexPart> = parts.iter().map(|p| p.into()).collect();
150148
serializable.serialize(serializer)
151149
}
152150

0 commit comments

Comments
 (0)