Skip to content

Commit 594fb5e

Browse files
authored
[DevTools] Always skip 1 frame (facebook#34167)
Follow up to facebook#34093. There's an issue where the skipFrames argument isn't part of the cache key so the other parsers that expect skipping one frame might skip zero and show the internal `fakeJSXDEV` callsite. Ideally we should include the skipFrames as part of the cache key but we can also always just skip one.
1 parent 98286cf commit 594fb5e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-devtools-shared/src/backend/utils/parseStackTrace.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ export function parseStackTrace(
284284
export function extractLocationFromOwnerStack(
285285
error: Error,
286286
): ReactFunctionLocation | null {
287-
const stackTrace = parseStackTrace(error, 0);
287+
const stackTrace = parseStackTrace(error, 1);
288288
const stack = error.stack;
289289
if (
290290
!stack.includes('react_stack_bottom_frame') &&

0 commit comments

Comments
 (0)