pr review

zeitlinger · zeitlinger · commit 5e05e30d204f · 2025-10-08T16:27:03.000+02:00
diff --git a/muzzle/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/AgentCachingPoolStrategy.java b/muzzle/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/AgentCachingPoolStrategy.java
@@ -146,6 +146,7 @@ public AgentTypePool typePool(
     return typePool(classFileLocator, classLoader);
   }
 
+  // visible for testing
   TypePool.CacheProvider getCacheProvider(ClassLoader classLoader) {
     if (classLoader == null) {
       return bootstrapCacheProvider;
@@ -167,6 +168,7 @@ TypePool.CacheProvider getCacheProvider(ClassLoader classLoader) {
    *
    * <p>The loaderHash exists to avoid calling get & strengthening the Reference.
    */
+  // visible for testing
   static final class TypeCacheKey {
     private final int loaderHash;
     @Nullable private final WeakReference<ClassLoader> loaderRef;

Original file line number	Diff line number	Diff line change
`@@ -146,6 +146,7 @@ public AgentTypePool typePool(`
`146`	`146`	`return typePool(classFileLocator, classLoader);`
`147`	`147`	`}`
`148`	`148`
	`149`	`+ // visible for testing`
`149`	`150`	`TypePool.CacheProvider getCacheProvider(ClassLoader classLoader) {`
`150`	`151`	`if (classLoader == null) {`
`151`	`152`	`return bootstrapCacheProvider;`
`@@ -167,6 +168,7 @@ TypePool.CacheProvider getCacheProvider(ClassLoader classLoader) {`
`167`	`168`	`*`
`168`	`169`	`* <p>The loaderHash exists to avoid calling get & strengthening the Reference.`
`169`	`170`	`*/`
	`171`	`+ // visible for testing`
`170`	`172`	`static final class TypeCacheKey {`
`171`	`173`	`private final int loaderHash;`
`172`	`174`	`@Nullable private final WeakReference<ClassLoader> loaderRef;`