Skip to content

Commit 586a540

Browse files
committed
[Host] Correct interface checks for IMessageSerializerProvider
Signed-off-by: Tomasz Maruszak <[email protected]>
1 parent c69c06b commit 586a540

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

src/SlimMessageBus.Host.Configuration/Builders/MessageBusBuilder.cs

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -236,22 +236,22 @@ public MessageBusBuilder ExpectRequestResponses(Action<RequestResponseBuilder> r
236236
}
237237

238238
/// <summary>
239-
/// Serializer type (<see cref="IMessageSerializer"/>) to look up in the DI for this bus.
239+
/// Serializer type (<see cref="IMessageSerializerProvider"/>) to look up in the DI for this bus.
240240
/// </summary>
241241
/// <typeparam name="T"></typeparam>
242242
/// <returns></returns>
243-
public MessageBusBuilder WithSerializer<T>() where T : IMessageSerializer => WithSerializer(typeof(T));
243+
public MessageBusBuilder WithSerializer<T>() where T : IMessageSerializerProvider => WithSerializer(typeof(T));
244244

245245
/// <summary>
246-
/// Serializer type (<see cref="IMessageSerializer"/>) to look up in the DI for this bus.
246+
/// Serializer type (<see cref="IMessageSerializerProvider"/>) to look up in the DI for this bus.
247247
/// </summary>
248248
/// <typeparam name="T"></typeparam>
249249
/// <returns></returns>
250250
public MessageBusBuilder WithSerializer(Type serializerType)
251251
{
252-
if (serializerType is not null && !typeof(IMessageSerializer).IsAssignableFrom(serializerType))
252+
if (serializerType is not null && !typeof(IMessageSerializerProvider).IsAssignableFrom(serializerType))
253253
{
254-
throw new ConfigurationMessageBusException($"The serializer type {serializerType.FullName} does not implement the interface {nameof(IMessageSerializer)}");
254+
throw new ConfigurationMessageBusException($"The serializer type {serializerType.FullName} does not implement the interface {nameof(IMessageSerializerProvider)}");
255255
}
256256

257257
Settings.SerializerType = serializerType ?? throw new ArgumentNullException(nameof(serializerType));
@@ -265,10 +265,6 @@ public void RegisterSerializer<TMessageSerializerProvider>(Action<IServiceCollec
265265
PostConfigurationActions.Add(services => services.TryAddSingleton<IMessageSerializerProvider>(sp => sp.GetRequiredService<TMessageSerializerProvider>()));
266266
}
267267

268-
[Obsolete("Use WithServiceProvider()")]
269-
public MessageBusBuilder WithDependencyResolver(IServiceProvider serviceProvider)
270-
=> WithServiceProvider(serviceProvider);
271-
272268
public MessageBusBuilder WithServiceProvider(IServiceProvider serviceProvider)
273269
{
274270
Settings.ServiceProvider = serviceProvider ?? throw new ArgumentNullException(nameof(serviceProvider));

src/SlimMessageBus.Host/Consumer/MessageProcessors/MessageProcessor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public async virtual Task<ProcessMessageResult> ProcessMessage(TTransportMessage
9494

9595
if (messageType != null)
9696
{
97-
var message = _messageProvider(messageType, messageHeaders, transportMessage);
97+
var message = _messageProvider(messageType, messageHeaders, transportMessage);
9898
try
9999
{
100100
var consumerInvokers = TryMatchConsumerInvoker(messageType);

src/SlimMessageBus.Host/MessageBusSettingsExtensions.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22

33
public static class MessageBusSettingsExtensions
44
{
5-
public static IMessageSerializer GetSerializer(this MessageBusSettings settings, IServiceProvider serviceProvider) =>
6-
(IMessageSerializer)serviceProvider.GetService(settings.SerializerType)
7-
?? throw new ConfigurationMessageBusException($"The bus {settings.Name} could not resolve the required message serializer type {settings.SerializerType.Name} from {nameof(serviceProvider)}");
8-
95
public static IMessageSerializerProvider GetSerializerProvider(this MessageBusSettings settings, IServiceProvider serviceProvider) =>
10-
(IMessageSerializerProvider)serviceProvider.GetService(settings.SerializerType)
11-
?? throw new ConfigurationMessageBusException($"The bus {settings.Name} could not resolve the required message serializer type {settings.SerializerType.Name} from {nameof(serviceProvider)}");
6+
serviceProvider.GetService(settings.SerializerType) as IMessageSerializerProvider
7+
?? throw new ConfigurationMessageBusException($"The bus {settings.Name} could not resolve the required {nameof(IMessageSerializerProvider)} of type {settings.SerializerType.Name} from {nameof(serviceProvider)}");
128
}

0 commit comments

Comments
 (0)